Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the suite of automated tests of the Harvesting functionality #8843

Closed
landreev opened this issue Jul 14, 2022 · 3 comments · Fixed by #9227
Closed

Expand the suite of automated tests of the Harvesting functionality #8843

landreev opened this issue Jul 14, 2022 · 3 comments · Fixed by #9227
Assignees
@landreev
Labels
Feature: Harvesting NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues pm.GREI-d-1.4.2 NIH, yr1, aim4, task2: Create working group on packaging standards Size: 80 A percentage of a sprint. 56 hours.
Milestone
5.13

Comments

@landreev
Copy link
Contributor

A followup issue for #8372 (PR #8753).
The existing restassured tests are fairly primitive. We need tests covering all the OAI functionality we provide.
@landreev landreev mentioned this issue Aug 25, 2022
Closed
@pdurbin
Copy link
Member

pdurbin commented Oct 1, 2022

Obviously, there are lots of tests we could write. This might be a good one:

@pdurbin pdurbin mentioned this issue Oct 1, 2022
Closed
3 tasks
@mreekie mreekie added NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... and removed NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... labels Oct 25, 2022
@mreekie mreekie moved this to NIH (Stefano) in IQSS Dataverse Project Nov 2, 2022
@mreekie mreekie moved this from NIH bklog#000 (Stefano) to 1️⃣ 📃✔▶ORDERED BACKLOG (Stefano) in IQSS Dataverse Project Nov 21, 2022
@mreekie mreekie moved this from 1️⃣ ▶ORDERED BACKLOG (Stefano) to 2️⃣▶ SPRINT PREP in IQSS Dataverse Project Nov 22, 2022
@mreekie mreekie mentioned this issue Nov 22, 2022
Closed
@pdurbin pdurbin added the Size: 80 A percentage of a sprint. 56 hours. label Nov 29, 2022
@pdurbin
Copy link
Member

pdurbin commented Nov 29, 2022

@landreev added some tests in this PR:

The idea of this issue is to add more tests to cover all the harvesting functionality. I'm not sure exactly how much time this will take so I'd suggest we timebox it to a full sprint (2 weeks) for a single developer (maybe @landreev but any of us could jump in) to see how much can get done. Giving it an 80.

Review and QA should be light. As long as the tests pass, we should be good.

I don't believe we have a good way of checking code coverage for API tests like this (red/green per line).

@pdurbin pdurbin moved this from 2️⃣▶ SPRINT PREP (Tech discussion/Sizing) to 3️⃣▶ 💨👟SPRINT READY in IQSS Dataverse Project Nov 29, 2022
@mreekie mreekie moved this from 3️⃣▶ 💨👟SPRINT READY to 🏁In a Sprint or Completed in IQSS Dataverse Project Dec 1, 2022
@landreev landreev self-assigned this Dec 1, 2022
landreev added a commit that referenced this issue Dec 2, 2022
@landreev
rc2 version of the gdcc-xoai lib. should've been done a long time ago…
175ab7f 
… :( #8843
landreev added a commit that referenced this issue Dec 2, 2022
@landreev
this method was renamed in RC2 (#8843)
3d1e98c
landreev added a commit that referenced this issue Dec 9, 2022
@landreev
a few extra oai tests (#8843)
aeffa3b
landreev added a commit that referenced this issue Dec 9, 2022
@landreev
more tests for the OAI server functionality (#8843)
c4f07f9
landreev added a commit that referenced this issue Dec 12, 2022
@landreev
extra (extra tedious) server tests validating paging (resumptionToken…
9cbfa31 
…) functionality of ListIdentifiers and ListRecords (#8843)
landreev added a commit that referenced this issue Dec 12, 2022
@landreev
An automated test of an actual harvest (#8843)
395d605
landreev added a commit that referenced this issue Dec 12, 2022
@landreev
comments (#8843)
bc90f5c
@mreekie
Copy link

mreekie commented Dec 13, 2022

Working out a PR today.
There will be more review than QA.
Should be able to wrap up by the end of the sprint

landreev added a commit that referenced this issue Dec 13, 2022
@landreev
logic! (#8843)
8e310c3
landreev added a commit that referenced this issue Dec 13, 2022
@landreev
cleanup (#8843)
b5986fa
@landreev landreev mentioned this issue Dec 13, 2022
Merged
landreev added a commit that referenced this issue Dec 14, 2022
@landreev
one more jenkins run, with a bit more logging (#8843)
abd6ded
landreev added a commit that referenced this issue Dec 14, 2022
@landreev
trigger another Jenkins run, with the time delay slightly rearranged …
f6d08bb 
…in the wait for an async. operation + some extra logging (#8843)
@pdurbin pdurbin added this to the 5.13 milestone Dec 15, 2022
@sync-by-unito sync-by-unito bot mentioned this issue Mar 3, 2023
Closed
3 tasks
@mreekie mreekie moved this to 🚮Clear of the Backlog in IQSS Dataverse Project Jan 28, 2023
@mreekie mreekie added pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues pm.GREI-d-1.4.2 NIH, yr1, aim4, task2: Create working group on packaging standards labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@landreev landreev

Labels
Feature: Harvesting NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues pm.GREI-d-1.4.2 NIH, yr1, aim4, task2: Create working group on packaging standards Size: 80 A percentage of a sprint. 56 hours.
Projects
IQSS Dataverse Project
Status: No status
Milestone
5.13
Development

Successfully merging a pull request may close this issue.

8843 more harvest tests IQSS/dataverse
3 participants
@pdurbin @landreev @mreekie