Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploaded file detected as duplicate after deletion and re-upload #10313

Open
atniph opened this issue Feb 9, 2024 · 5 comments
Open

Uploaded file detected as duplicate after deletion and re-upload #10313

atniph opened this issue Feb 9, 2024 · 5 comments
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: File Upload & Handling Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug - Blocker Bug is blocking user work, no workaround available Type: Bug a defect UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF Vote to Close: pdurbin

Comments

@atniph
Copy link

atniph commented Feb 9, 2024

What steps does it take to reproduce the issue?

  1. Upload a new file to any dataset.
  2. Delete the uploaded file from the files list.
  3. Attempt to re-upload the same file.
  • What happens?

The system detects the re-uploaded file as a duplicate, despite being deleted previously.

  • What did you expect to happen?

The system should allow re-uploading the file without considering it as a duplicate since it was previously deleted.

Which version of Dataverse are you using?

v6.1

Screenshots:

Screenshot 2024-02-09 at 15 17 58
@atniph atniph added the Type: Bug a defect label Feb 9, 2024
@pdurbin
Copy link
Member

pdurbin commented Feb 12, 2024

@atniph wow, what a weird bug. We should hire you to do QA for us! 😄 Thanks for letting us know!

@pdurbin pdurbin added Feature: File Upload & Handling Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF labels Feb 12, 2024
@sbarbosadataverse sbarbosadataverse moved this to SPRINT- NEEDS SIZING in IQSS Dataverse Project Jun 26, 2024
@sbarbosadataverse
Copy link

This was reported recently by another use in HDV.

We need to confirm if any additional steps are missing from the report:

@atniph can you confirm if any steps are missing:

  1. Did you upload the files, select save, and then delete the files and try to reupload again?
  2. Did you upload files, not save, delete them, and try to reupload them?

We aren't able to duplicate with the steps you listed to get the same message you posted " deleting duplicates."

Thanks

@cmbz cmbz added the Type: Bug - Blocker Bug is blocking user work, no workaround available label Jul 1, 2024
@cmbz
Copy link

cmbz commented Nov 21, 2024

2024/11/21:

  • Next step: try to recreate problem. Sizing at 3 to test it out. Resize as needed once you perform the test.

@cmbz cmbz added the Size: 3 A percentage of a sprint. 2.1 hours. label Nov 21, 2024
@pdurbin
Copy link
Member

pdurbin commented Dec 20, 2024

I was able to reproduce this. I stayed entirely on the "create dataset" page. That is, I'm on http://localhost:8080/dataset.xhtml?ownerId=1 when the error happened.

  • Click "create dataset"
  • Fill in required fields
  • Scroll down and click "select files to add"
  • Upload a file
  • Delete the file
  • Upload the same file
  • Expect an error like this:

Screenshot 2024-12-20 at 2 42 40 PM

Is this bug worth fixing, though? @atniph do you want to try it on the new (React) UI at https://beta.dataverse.org/spa/ to see if you can reproduce it there? We are throwing the old (JSF) UI in the trash soon so I don't think it's worth fixing. 🗑️ /cc @cmbz @scolapasta @sbarbosadataverse

@pdurbin
Copy link
Member

pdurbin commented Dec 20, 2024

do you want to try it on the new (React) UI

I just tried. I don't think we'll have this problem with the new UI because it forces you to create the dataset first before you can upload any files. Note how there is no "upload files" button at the bottom of the "create dataset" page:

Screenshot 2024-12-20 at 2 49 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: File Upload & Handling Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug - Blocker Bug is blocking user work, no workaround available Type: Bug a defect UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF Vote to Close: pdurbin
Projects
Status: SPRINT READY
Development

No branches or pull requests

4 participants