From e64a81d18d8d68ca6efc1dcbf3c37c81244d7e54 Mon Sep 17 00:00:00 2001 From: Leonid Andreev Date: Wed, 13 Jul 2022 10:19:50 -0400 Subject: [PATCH] try-with-resources for the xmlwriter in the servlet (#8372) --- .../dataverse/harvest/server/web/servlet/OAIServlet.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/main/java/edu/harvard/iq/dataverse/harvest/server/web/servlet/OAIServlet.java b/src/main/java/edu/harvard/iq/dataverse/harvest/server/web/servlet/OAIServlet.java index 8cbde519446..2b3e327e5d2 100644 --- a/src/main/java/edu/harvard/iq/dataverse/harvest/server/web/servlet/OAIServlet.java +++ b/src/main/java/edu/harvard/iq/dataverse/harvest/server/web/servlet/OAIServlet.java @@ -238,10 +238,9 @@ private void processRequest(HttpServletRequest httpServletRequest, HttpServletRe OAIPMH handle = dataProvider.handle(rawRequest); response.setContentType("text/xml;charset=UTF-8"); - XmlWriter xmlWriter = new XmlWriter(response.getOutputStream(), repositoryConfiguration); - xmlWriter.write(handle); - xmlWriter.flush(); - xmlWriter.close(); + try (XmlWriter xmlWriter = new XmlWriter(response.getOutputStream(), repositoryConfiguration);) { + xmlWriter.write(handle); + } } catch (IOException ex) { logger.warning("IO exception in Get; "+ex.getMessage());