Skip to content

Commit 9247be6

Browse files
🎨 Style(src): remove unnecessary eslint-disable lines
1 parent 85d4473 commit 9247be6

File tree

9 files changed

+59
-67
lines changed

9 files changed

+59
-67
lines changed

‎.env

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
ESLINT_USE_FLAT_CONFIG = true
1+
ESLINT_USE_FLAT_CONFIG = true
2+

‎eslint.config.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ export default ineedj({
88
stylisticTS: false,
99
perfectionistSorters: false
1010
},
11+
modifiers: {
12+
commands: true
13+
},
1114
syntax: {
1215
vitest: true,
1316
eslint: true,

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"devDependencies": {
5454
"@changesets/cli": "^2.27.8",
5555
"@esplugins/no-internal-exports": "^1.0.0",
56-
"@ineedj/eslintrc": "^1.2.2",
56+
"@ineedj/eslintrc": "^1.2.3",
5757
"@ineedj/prettierrc": "^2.0.0",
5858
"@ineedj/tsconfig": "^1.0.0",
5959
"@types/eslint": "~9.6.1",

‎pnpm-lock.yaml

Lines changed: 20 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/functions/myError.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable @EslintSonar/no-duplicate-string */
21
import { describe, it, expect } from "vitest";
32
import { myError } from "./myError";
43
import type { IMyError, TMyErrorList } from "@/types";

‎src/functions/myError.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
2-
32
/* eslint-disable @typescript-eslint/no-explicit-any */
43

54
import type { IMyError } from "@/types";
@@ -57,13 +56,11 @@ type ErrorArgs<T> = {
5756
* ```
5857
*/
5958

60-
export function myError<T extends NonNullable<unknown> = IMyError>(errorObj: T, args?: ErrorArgs<T>): T {
59+
export const myError = <T extends NonNullable<unknown> = IMyError>(errorObj: T, args?: ErrorArgs<T>): T => {
6160
const result = { ...errorObj };
62-
6361
if (args) {
6462
for (const key in args) {
6563
if (!(key in result)) continue; // Check that `key` from args exist in result (errorT)
66-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
6764
if (typeof result[key] === "function") {
6865
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
6966
result[key] = (result[key] as (...args: any[]) => any)(...(args[key] as any[])); // TODO: Change this later and remove eslint ignore above
@@ -77,4 +74,4 @@ export function myError<T extends NonNullable<unknown> = IMyError>(errorObj: T,
7774
}
7875

7976
return result;
80-
}
77+
};

‎src/functions/myErrorCatcher.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ export const myErrorCatcher =
44
<T extends arrowFunction<T>>(functionThatMayThrow: T) =>
55
async (...arguments_: Parameters<T>): Promise<ReturnType<T>> =>
66
new Promise(resolve => {
7-
// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-argument
87
resolve(functionThatMayThrow(...arguments_));
98
});
109

Lines changed: 31 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,9 @@
1-
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
2-
/* eslint-disable @typescript-eslint/no-unsafe-call */
3-
/* eslint-disable @typescript-eslint/no-unsafe-return */
4-
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
51
import { describe, expect, test } from "vitest";
6-
import myErrorWrapper, { myErrorWrapperAsync } from "./myErrorWrapper";
2+
import { myErrorWrapper } from "./myErrorWrapper";
73
import { myError } from "./myError";
84
import type { TMyErrorList } from "@/types";
95

106
describe("[FUNCTION] myErrorWrapper", () => {
11-
describe("[PASS]", () => {
12-
test("Double ()", () => {
13-
const sum = (sum1: number, sum2: number) => sum1 + sum2;
14-
15-
const [data, isError] = myErrorWrapper(sum)(1, 2);
16-
expect(isError).toEqual(false);
17-
expect(data).toEqual(3);
18-
});
19-
test("Single ()", () => {
20-
const sum = (sum1: number, sum2: number) => sum1 + sum2;
21-
22-
const [data, isError] = myErrorWrapper(() => sum(1, 2))();
23-
expect(isError).toEqual(false);
24-
expect(data).toEqual(3);
25-
});
26-
test("Async Single ()", async () => {
27-
const sum = async (sum1: number, sum2: number) => (await sum1) + sum2;
28-
29-
const [data, isError] = await myErrorWrapperAsync(async () => sum(1, 2))();
30-
expect(isError).toEqual(false);
31-
expect(data).toEqual(3);
32-
});
33-
test("Async Double ()", async () => {
34-
const sum = async (sum1: number, sum2: number) => (await sum1) + sum2;
35-
36-
const [data, isError] = await myErrorWrapperAsync(sum)(1, 2);
37-
expect(isError).toEqual(false);
38-
expect(data).toEqual(3);
39-
});
40-
});
417
describe("[ERROR]", () => {
428
test("Double ()", () => {
439
const errorFunc = () => {
@@ -76,4 +42,34 @@ describe("[FUNCTION] myErrorWrapper", () => {
7642
expect(error).toEqual(myError(MyErrorList.TOO_HIGH_NUMBER));
7743
});
7844
});
45+
describe("[PASS]", () => {
46+
test("Double ()", () => {
47+
const sum = (sum1: number, sum2: number) => sum1 + sum2;
48+
49+
const [data, isError] = myErrorWrapper(sum)(1, 2);
50+
expect(isError).toEqual(false);
51+
expect(data).toEqual(3);
52+
});
53+
test("Single ()", () => {
54+
const sum = (sum1: number, sum2: number) => sum1 + sum2;
55+
56+
const [data, isError] = myErrorWrapper(() => sum(1, 2))();
57+
expect(isError).toEqual(false);
58+
expect(data).toEqual(3);
59+
});
60+
test("Async Single ()", async () => {
61+
const sum = async (sum1: number, sum2: number) => (await sum1) + sum2;
62+
63+
const [data, isError] = await myErrorWrapper(async () => sum(1, 2))();
64+
expect(isError).toEqual(false);
65+
expect(data).toEqual(3);
66+
});
67+
test("Async Double ()", async () => {
68+
const sum = async (sum1: number, sum2: number) => (await sum1) + sum2;
69+
70+
const [data, isError] = await myErrorWrapper(sum)(1, 2);
71+
expect(isError).toEqual(false);
72+
expect(data).toEqual(3);
73+
});
74+
});
7975
});

‎src/types/internal.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ export type TMyHandler<
4747
// export type TMyHandler<T extends TMyErrorList> = Partial<{
4848
// [K in T[keyof T]["code"]]: (...args: K[]) => TFunctionReturn<unknown>;
4949
// }>;
50-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
5150
/** @dontexport */
5251
// eslint-disable-next-line @typescript-eslint/no-explicit-any
5352
export type NoInfer<T> = [T][T extends any ? 0 : never];

0 commit comments

Comments
 (0)