Switch to using UUIDs to name different MQTT clients

Author: twright

Cargo.toml

@@ -29,10 +29,13 @@ serde_json = "1.0.137"
 paho-mqtt = {version = "0.13.0", default-features=false, features=["bundled", "ssl"]}
 async-trait = "0.1.85"
 async-once-cell = "0.5.4"
-random = "0.14.0"
-rand = "0.8.5"
 tracing = {version = "0.1.41", features = ["attributes", "std", "tracing-attributes", "async-await"]}
 tracing-subscriber = {version="0.3.19", features=["env-filter", "fmt"]}
+uuid = {version = "1.12.1", features = [
+    "v4",                # Lets you generate random UUIDs
+    "fast-rng",          # Use a faster (but still sufficiently random) RNG
+    "macro-diagnostics", # Enable better diagnostics for compile-time UUIDs
+]}
 
 [features]
 ros = ["dep:r2r"]

src/mqtt_client.rs

@@ -4,6 +4,7 @@ use async_stream::stream;
 use futures::{stream::BoxStream, StreamExt};
 use paho_mqtt::{self as mqtt, Message};
 use tracing::{debug, info, instrument, warn, Level};
+use uuid::Uuid;
 
 type Hostname = String;
 
@@ -45,7 +46,7 @@ pub async fn provide_mqtt_client_with_subscription(
         .server_uri(hostname.clone())
         .client_id(format!(
             "robosapiens_trustworthiness_checker_{}",
-            rand::random::<u16>()
+            Uuid::new_v4()
         ))
         .finalize();
 
@@ -87,7 +88,7 @@ pub async fn provide_mqtt_client(hostname: Hostname) -> Result<mqtt::AsyncClient
         .server_uri(hostname.clone())
         .client_id(format!(
             "robosapiens_trustworthiness_checker_{}",
-            rand::random::<u16>()
+            Uuid::new_v4()
         ))
         .finalize();