Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kicad_dnp in Pick & place #605

Open
hardwaremaker opened this issue Apr 7, 2024 · 2 comments
Open

Use kicad_dnp in Pick & place #605

hardwaremaker opened this issue Apr 7, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request needs more info Further information is requested

Comments

@hardwaremaker
Copy link

Currently, the output type "position" does not recognize the kicad dnp flag. Would be very helpful to have this option.

@hardwaremaker hardwaremaker added the enhancement New feature or request label Apr 7, 2024
@set-soft
Copy link
Member

set-soft commented Apr 8, 2024

Please elaborate, currently you must apply a filter in order to get components filtered. And if you apply filters then the following option controls the KiCad DNP flag:

            self.kicad_dnp_applied = True
            """ The KiCad v7 PCB flag *Do Not Populate* is applied to our fitted flag before running any filter """

Do you want an option to make it happen even when no filters are applied?
Note that currently any filter will do the work:

def reset_filters(comps):
    logger.debug('Filters reset')
    for c in comps:
        c.included = True
        # If the global kicad_dnp_applied variable is True try to copy the DNP flag from KiCad v7
        c.fitted = not GS.global_kicad_dnp_applied or c.kicad_dnp is None or not c.kicad_dnp
        c.fixed = False
        c.back_up_fields()

@set-soft set-soft added the needs more info Further information is requested label Apr 19, 2024
@set-soft
Copy link
Member

set-soft commented May 7, 2024

Hi @hardwaremaker !

If you don't clarify your request I'll just close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs more info Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants