Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main menu revisions and updates #161

Open
5 tasks done
benlk opened this issue Jul 7, 2020 · 3 comments
Open
5 tasks done

Main menu revisions and updates #161

benlk opened this issue Jul 7, 2020 · 3 comments
Labels
Priority: High Type: Bug/Issue

Comments

@benlk
Copy link
Collaborator

benlk commented Jul 7, 2020 •
edited
Loading

  • Dropdowns in fullscreen menu need text contrast work: Screen Shot 2020-07-07 at 12 09 40
  • remove whitespace margin at bottom of menu by applying margin-bottom: 0: Screen Shot 2020-09-03 at 17 33 05
  • Fix JS that is making it so that, on touch devices, the dropdowns do dropdown
  • increase tap target size on b.caret in the opened hamburger menu
  • change color of b.caret in the opened hamburger menu and maybe add a border?
@benlk benlk changed the title Dropdowns in fullscreen menu need text contrast work Main menu revisions and updates Sep 3, 2020
@benlk
Copy link
Collaborator Author

benlk commented Sep 3, 2020

Blocked by decision on what color the non-hover colors should be for dropdown text:

Screen Shot 2020-09-03 at 17 36 31

Is it okay to go with the plain orange and let the background color be the sole distinguishing factor?

@kaylima
Copy link
Member

kaylima commented Sep 5, 2020

Is it okay to go with the plain orange and let the background color be the sole distinguishing factor?

Yes, orange is fine with white background for non-hover @benlk

@benlk benlk mentioned this issue Sep 9, 2020
Merged
2 tasks
@benlk
Copy link
Collaborator Author

benlk commented Sep 9, 2020 •
edited
Loading

umbrella-sfpublicpress/wp-content/themes/sfpublicpress/partials/nav-main.php

Line 9 in e524bd0

* - removes .nav-shelf class

JS issues come from much of navigation.js having a .nav-shelf selector which was removed from nav-main.php to avoid styles upon it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: High Type: Bug/Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benlk @kaylima