Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens on Lightfood Embed - Changes from partner feedback #137

Open
6 tasks done
MirandaEcho opened this issue Jan 22, 2020 · 7 comments
Open
6 tasks done

Lens on Lightfood Embed - Changes from partner feedback #137

MirandaEcho opened this issue Jan 22, 2020 · 7 comments
Assignees

Comments

@MirandaEcho
Copy link
Collaborator

MirandaEcho commented Jan 22, 2020

  • Add published date (likely via description as discussed)
  • Ensure headlines have consistent capitalization
  • Create a Google Form
  • Add a button to the embed that says "Submit a story idea" on the front end
  • Change language in embed from instead of "Stories from the Project" to "Seven independent newsrooms report on Mayor Lori Lightfoot’s first year"
  • Logo should link to the project landing page (http://inndev.staging.wpengine.com/lens-on-lightfoot/) rather than the Amplify landing page

@joshdarby - I can help with some of these as well.

@MirandaEcho
Copy link
Collaborator Author

MirandaEcho commented Jan 22, 2020

Additional landing page tweaks (likely also Miranda):

  • Find a better way to display logos so they're all "together"
  • Link logos to partner sites
  • Move story embed further up the page (@joshdarby is it possible to have a sidebar on this page with this template?)

@joshdarby
Copy link

joshdarby commented Jan 23, 2020

Ensure headlines have consistent capitalization

@MirandaEcho Do we want to do this via css or manually for each link? We can do it via css using text-transform: capitalize but that capitalizes every first letter of every single word, so for example,
Lightfoot’s Effort To Scale Back Aldermanic Prerogative a Work in Progress
would become
Lightfoot’s Effort To Scale Back Aldermanic Prerogative A Work In Progress,
which I don't think we want the a or in capitalized.

@joshdarby
Copy link

Move story embed further up the page (@joshdarby is it possible to have a sidebar on this page with this template?)

@MirandaEcho Yep. Added.

@joshdarby
Copy link

@MirandaEcho Is this button ok or do you want it placed somewhere different/designed differently? (Don't pay attention to the embed layout)

Screen Shot 2020-01-23 at 10 43 58 AM

@MirandaEcho
Copy link
Collaborator Author

Ensure headlines have consistent capitalization

@MirandaEcho Do we want to do this via css or manually for each link? We can do it via css using text-transform: capitalize but that capitalizes every first letter of every single word, so for example,
Lightfoot’s Effort To Scale Back Aldermanic Prerogative a Work in Progress
would become
Lightfoot’s Effort To Scale Back Aldermanic Prerogative A Work In Progress,
which I don't think we want the a or in capitalized.

@joshdarby they want only the first word capitalized, so we probably have to do it manually. I can do that.

@MirandaEcho
Copy link
Collaborator Author

@MirandaEcho Is this button ok or do you want it placed somewhere different/designed differently? (Don't pay attention to the embed layout)

Screen Shot 2020-01-23 at 10 43 58 AM

Looks good to me!

@joshdarby
Copy link

Add a button to the embed that says "Submit a story idea" on the front end

I know we talked about how this needs to be dynamic for every different "project", and we talked about how we could probably use the More Link field on the tag for the form url. I didn't realize we are already using the field for the logo url.

So, the next best option would be to hardcode the button on the feed and have it accept the ID of the google form as a query parameter, such as gform_id=1FAIpQLSfE8R0oGwgaAcczd_pPdebrlM22RQ_kaewZZKrBEhjyHWtjSA and then link to https://docs.google.com/forms/d/e/FORM_ID_PASSED_IN. This isn't something members or anyone else would need to worry about. It would only be changed/modified by us when creating the embed. This way we can still pass in a dynamic form id for each different project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants