Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup form on all mobile pages #84

Open
MirandaEcho opened this issue Feb 11, 2020 · 5 comments
Open

Signup form on all mobile pages #84

MirandaEcho opened this issue Feb 11, 2020 · 5 comments
Assignees
Milestone

Comments

@MirandaEcho
Copy link
Collaborator

We need an estimate for what it would take to add a signup form to all mobile pages on the site. This could be in the mobile nav, adding a section to the top that only displays on mobile, etc. We can discuss at scrum if needed, otherwise please add thoughts on an estimate here. Thanks!

@benlk
Copy link
Collaborator

benlk commented Feb 11, 2020

A newsletter signup form already exists on most pages on the site, in the main sidebar. However, this form is currently hidden from view on mobile, as seen on https://energynews.us/digests/natural-gas-bans-draw-skepticism-from-utility-regulators/ and https://energynews.us/2020/02/11/west/colorado-legislators-take-up-proposal-for-renewable-natural-gas-standard/

What we could do is put the newsletter signup form back at the start of articles. We did this before (and removed it in #68 because the form was the wrong form). If we were to take this same approach, we'd want to, instead of putting a widget directly at the top of articles, create an "Article Top" widget area to match "Article Bottom", and output that widget area at the top of the article.

Combined with making sure that the newsletter signup form output at the top of articles looks good, I think this might take 2-4h?

@benlk
Copy link
Collaborator

benlk commented Feb 11, 2020

the idea is to have a form at the very top of all pages on mobile

We can use the "Header Ad Zone" widget area. Improvements to styling, once we know what signup form we're using, would take up to two hours.

Here's what the current "ENN Mailchimp Signup" widget looks like in the "Header Ad Zone" widget area on article pages:

Screen Shot 2020-02-11 at 12 27 53

It has a slightly different appearance on term archives and the homepage:

Screen Shot 2020-02-11 at 12 28 59
Screen Shot 2020-02-11 at 12 29 11

@MirandaEcho
Copy link
Collaborator Author

We have approval from Ken to proceed with this for an additional two hours, so I'll update it when I update the rest of the issues.

@MirandaEcho MirandaEcho changed the title ESTIMATE NEEDED: Signup form on all mobile pages Signup form on all mobile pages Feb 18, 2020
@MirandaEcho MirandaEcho added this to the FRES-011 milestone Feb 18, 2020
@benlk
Copy link
Collaborator

benlk commented Feb 18, 2020

Config:

  • add widget to widget area
  • set widget to only show on mobile

Dev:

  • consistency of styles

Admin:

  • add note to the deployment issue

@benlk
Copy link
Collaborator

benlk commented Feb 19, 2020

PR #88 now ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants