Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS breaks pym-shortcode #42

Closed
lajoiemedia opened this issue Jul 29, 2020 · 3 comments
Closed

CSS breaks pym-shortcode #42

lajoiemedia opened this issue Jul 29, 2020 · 3 comments

Comments

@lajoiemedia
Copy link
Collaborator

In the CPIPR child theme's style.css is this bit of CSS:

.iframe-youtube,
iframe {
  width: 100%;
  margin-top: 9px;
  height: 560px;
}

This CSS sets all iframes to 560px in height, everywhere. This obviously breaks the pym-shortcode responsive iframe plugin, and is a dangerous bit of CSS that will interfere with any plugins that rely on iframes.

There must be a more specific way to do whatever this CSS was intended to do.

I am working on a project that will rely on pym-shortcode heavily, so this is a major problem for me.

@rocaiguina
Copy link
Collaborator

@lajoiemedia I think it is safe to get rid of the 'iframe' and leave just the .iframe-youtube class

@lajoiemedia
Copy link
Collaborator Author

OK, do you want to do it or do you want me to submit a PR?

@rocaiguina
Copy link
Collaborator

rocaiguina commented Jul 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants