Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for non-lazy-load ads not displaying correctly #97

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Feb 7, 2019

Changes

Why

For #95 and #96.

Resolves #94

Testing/Questions

Questions that need to be answered before merging:

  • Does it update the changelog in readme.txt with appropriate information?

Steps to test this PR:

  1. Create a non-lazy-load ad widget in the page, with size mappings.
  2. With version 0.3, verify that the plugin doesn't request a correct ad size
  3. With this PR, verify that the plugin does request a correct ad size .

@benlk benlk added the bug label Feb 7, 2019
@benlk benlk added this to the 0.3.1 milestone Feb 7, 2019
@benlk
Copy link
Collaborator Author

benlk commented Feb 7, 2019

@benlk
Copy link
Collaborator Author

benlk commented Feb 7, 2019

Test release of this plugin created: https://github.com/INN/doubleclick-for-wp/archive/v0.3.1-rc1.zip

Submitted to that one wp.org user for testing: https://wordpress.org/support/topic/do-not-use-version-0-3/#post-11181996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant