Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: making data_vars related columns optional? #137

Closed
matentzn opened this issue Jun 18, 2019 · 2 comments
Closed

Question: making data_vars related columns optional? #137

matentzn opened this issue Jun 18, 2019 · 2 comments
Assignees

Comments

@matentzn
Copy link

For our use case, we would like to be able to omit the necessity of a data_var column to avoid breaking every pipeline ever; right now, the way we have specified the synonym field, dosdp-tools appears to require the presence of an actual column in the dosdp file. We need to be able to evolve annotation related fields on patterns without breaking existing pipelines (i.e. add a property). Is there any way we can currently do that? @dosumis @balhoff

@dosumis
Copy link

dosumis commented Jul 9, 2019

Nico & I have discussed this. While it is not safe to make vars that refer to OWL entities optional unless we have a system for specifying default values, it is perfectly safe to allow data_vars and data_list_vars to be optional. I think the behaviour of DOSDP-tools should be to allow TSVs missing columns for any data_var or data_list var in a DOSDP and where columns are present to allow for empty cells. In these cases, no annotation axiom should be generated. I don't think any change to the DOSDP formal spec is required for this, although we might want to extend field descriptions to clarify expected behaviour.

This has become quite urgent for uPheno. @balhoff - how easy would this be to implement?

@matentzn
Copy link
Author

@balhoff Sooooooorrrrryyyyyyy, buuuuuut: Were you planning to get this issue fixed soon? And this one? Much love. Thanks. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants