Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the naming conventions in DFR3 plotting methods - they are currently specific to fragilities #46

Open
ghost opened this issue Jan 25, 2022 · 0 comments
Labels
1storypoint Less than two hours of work, requiring only email communication

Comments

@ghost
Copy link

ghost commented Jan 25, 2022

With the recent changes to DFR3 service and pyincore, there is no difference in the methods used to plot any kind of DFR3 curves(F/R/R). But, the methods in pyincore code use fragility specific naming conventions. We should update them to be more generic, so the same methods can be used for plotting repairs, restorations etc.

example:

def get_fragility_plot(fragility_set, title=None, dimension=2, limit_state="LS_0",
                           custom_curve_parameters={}, **kwargs):

this can be called get_curve_plot() and limit_state can be removed or generalized, because for R/R this can be percent_functional ("PF_0")

@ghost ghost added this to the pyincore-viz-1.6.0 milestone Jan 25, 2022
@ghost ghost self-assigned this Mar 9, 2022
@ywkim312 ywkim312 removed this from the pyincore-viz-1.6.0 milestone Jun 27, 2022
@longshuicy longshuicy added the 1storypoint Less than two hours of work, requiring only email communication label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1storypoint Less than two hours of work, requiring only email communication
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants