Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip authorisation After First Consent (#112) #128

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Skip authorisation After First Consent (#112) #128

wants to merge 4 commits into from

Conversation

ktg-123
Copy link
Member

@ktg-123 ktg-123 commented Sep 27, 2020

No description provided.

dhruvkb
dhruvkb requested changes Sep 28, 2020
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before a review of the code, please reformat according to the code style.

omniport/core/open_auth/views/application.py
user=request.user,
application=request.GET.get('id')
).exists()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave exactly one newline between blocks of code and two lines between functions and classes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes. Please review

@ktg-123 ktg-123 changed the title Skip authorisation After First Consent Skip authorisation After First Consent (#112) Sep 28, 2020
@ktg-123 ktg-123 changed the title Skip authorisation After First Consent (#112) Skip authorisation After First Consent (#112) Sep 28, 2020
@ktg-123 ktg-123 requested a review from dhruvkb October 1, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvkb dhruvkb Awaiting requested review from dhruvkb

@shreyansh23 shreyansh23 Awaiting requested review from shreyansh23

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktg-123 @dhruvkb