Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub protections #265

Open
JohnMoehrke opened this issue Nov 15, 2022 · 6 comments
Open

GitHub protections #265

JohnMoehrke opened this issue Nov 15, 2022 · 6 comments
Assignees

Comments

@JohnMoehrke
Copy link
Contributor Author

I think that we should implement these kind of protections once a repo goes into TI publication. but I am not exactly sure, so would like discussion.
what rules should be applied, when, etc...

@JohnMoehrke
Copy link
Contributor Author

I did put these kind of rules in place for FormatCode repo.

@lukeaduncan
Copy link
Contributor

I think it's a good idea. I think for this repo and publications. We could start with only allow pull requests to update the main branch and require reviews of the pull request. If others seem useful we can certainly try them as well and see if it's more harmful than helpful.

For the others, I don't think it's as necessary since they only affect a CI build. Perhaps once something is final text we'd do the same protections as for publications and this?

Is this something we should discuss in a planning meeting or maybe at the next face to face? Even to just confirm or review after setting them up?

@JohnMoehrke
Copy link
Contributor Author

I think Trial-Implementation repos should also. Trying to think about the downside to that protection, and the only thing that comes up is updates needed simply due to the tooling changes (Grahame's fault).

@JohnMoehrke
Copy link
Contributor Author

I think we concluded on this, but can't find where I documented that. I would expect it should be documented in:

should it be a standalone article pointed to by these?

@JohnMoehrke JohnMoehrke transferred this issue from IHE/IT-Infrastructure Mar 21, 2023
@JohnMoehrke
Copy link
Contributor Author

JohnMoehrke commented Feb 14, 2024

Committee members should be given "Write" (is necessary to create pull-requests)
Committee co-chairs should be given "Admin" (unclear this or maintain)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants