Logstashsupport #128
Open
Logstashsupport #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarolopez
force-pushed
the
logstashsupport
branch
from
2db6777
to
6d2773e
Compare
alvarolopez
force-pushed
the
logstashsupport
branch
from
6d2773e
to
b3b86fa
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
=========================================
Coverage ? 50.93%
=========================================
Files ? 23
Lines ? 1127
Branches ? 160
=========================================
Hits ? 574
Misses ? 541
Partials ? 12 ☔ View full report in Codecov by Sentry. |
|
@alexcos78 I think that we need some unit tests for caso/messenger/logstash.py |
alvarolopez
requested changes
Sep 27, 2024
There was a problem hiding this comment.
@alexcos78 we need to fix the tests before merging, can you please have a look?
| @@ -49,11 +50,24 @@ def __init__(self, host=CONF.logstash.host, port=CONF.logstash.port): | |||
| self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) | |||
|
|
|||
| def push(self, records): | |||
| """Push records to logstash using tcp.""" | |||
There was a problem hiding this comment.
This docstring needs to be added again, as flake8 will complain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to send record to logstash. It solves issue #127
Fixes #127
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Running caso-extract sending record to logstash
Checklist: