Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show trend graph tab. #9132

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Always show trend graph tab. #9132

merged 1 commit into from
Jul 15, 2024

Conversation

fniessink
Copy link
Member

@fniessink fniessink commented Jul 3, 2024 •
edited
Loading

  • Show warning message when the metric has a version number scale that trend graphs are not supported.
  • Show warning message when the metric has no measurements yet.
  • Show loader when loading measurements.
  • Show warning message when loading failed.

Closes #8825.

@fniessink fniessink linked an issue Jul 3, 2024 that may be closed by this pull request
Always show Trend graph tab #8825
Closed
@fniessink fniessink force-pushed the 8825-always-show-trend-graph-tab branch 5 times, most recently from 84a3937 to aee5ff6 Compare July 4, 2024 13:37
@fniessink fniessink force-pushed the 8825-always-show-trend-graph-tab branch 5 times, most recently from 723bdc0 to 4fc81dd Compare July 8, 2024 21:40
@fniessink fniessink force-pushed the 8825-always-show-trend-graph-tab branch 2 times, most recently from f27e0cd to 2593c0a Compare July 9, 2024 11:30
@fniessink fniessink marked this pull request as ready for review July 9, 2024 11:30
@fniessink fniessink requested a review from wkoot July 9, 2024 11:31
@fniessink fniessink force-pushed the 8825-always-show-trend-graph-tab branch 2 times, most recently from 469a5f6 to e3b575c Compare July 9, 2024 11:41
wkoot
wkoot reviewed Jul 9, 2024
View reviewed changes
docs/src/changelog.md Outdated Show resolved Hide resolved
components/frontend/src/metric/TrendGraph.js Outdated Show resolved Hide resolved
@fniessink
Always show trend graph tab.
1650de0 
- Show warning message when the metric has a version number scale that trend graphs are not supported.
- Show warning message when the metric has no measurements yet.
- Show loader when loading measurements.
- Show warning message when loading failed.
@fniessink fniessink force-pushed the 8825-always-show-trend-graph-tab branch from e3b575c to 1650de0 Compare July 15, 2024 09:47
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@fniessink fniessink enabled auto-merge (rebase) July 15, 2024 09:54
@fniessink fniessink merged commit b5a3a74 into master Jul 15, 2024
41 checks passed
@fniessink fniessink deleted the 8825-always-show-trend-graph-tab branch July 15, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkoot wkoot wkoot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always show Trend graph tab
2 participants
@fniessink @wkoot