Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ABCSMC.__init__(summary_statistics) #426

Open
yannikschaelte opened this issue Feb 21, 2021 · 0 comments
Open

Remove ABCSMC.__init__(summary_statistics) #426

yannikschaelte opened this issue Feb 21, 2021 · 0 comments

Comments

@yannikschaelte
Copy link
Member

For major refactoring and the introduction of learned summary statistics, it would make sense to remove this Callable, which in most cases should anyway be an id mapping. Nothing is effectively lost, as the model can just return the "summary statistics / raw data" which are saved in the database. Only problem would be if this feature is used by many applicants. Opinions?

The summary statistics function would then mid-term be replaced by actual summary statistics, which are however not stored in the database, and act differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants