delete storageclass from cs cr (#2334)

* delete storageclass from cs cr

Signed-off-by: Allen Li <[email protected]>

* reduce duplicated deletion code

Signed-off-by: Allen Li <[email protected]>

* update file name

Signed-off-by: Allen Li <[email protected]>

* fix yq errors

Signed-off-by: Allen Li <[email protected]>

* remove comment

Signed-off-by: Allen Li <[email protected]>

* update info message

Signed-off-by: Allen Li <[email protected]>

* typo

Signed-off-by: Allen Li <[email protected]>

* Update preload_data.sh

Co-authored-by: Daniel Fan <[email protected]>
Signed-off-by: Allen Li <[email protected]>

* Update preload_data.sh

Co-authored-by: Daniel Fan <[email protected]>
Signed-off-by: Allen Li <[email protected]>

---------

Signed-off-by: Allen Li <[email protected]>
Co-authored-by: Daniel Fan <[email protected]>

Author: qpdpQ

preload_data.sh

@@ -202,25 +202,31 @@ function copy_resource() {
     local newResourceName=${3:-$resourceName}
     title " Copying $resourceType $resourceName from $FROM_NAMESPACE to $TO_NAMESPACE "   
     resource_exists=$(${OC} get $resourceType $resourceName -n $FROM_NAMESPACE || echo "fail")
+    storageClass_exist=$(${OC} get $resourceType $resourceName -n $FROM_NAMESPACE -o yaml | $YQ '.spec | has("storageClass")')
     if [[ $resource_exists != "fail" ]]; then
-      $OC get $resourceType $resourceName -n $FROM_NAMESPACE -o yaml | \
-          $YQ '
-              .metadata.name = "'$newResourceName'" |
+      $OC get $resourceType $resourceName -n $FROM_NAMESPACE -o yaml > tmp-resource.yaml 
+      $YQ -i '.metadata.name = "'${newResourceName}'" |
               del(.metadata.creationTimestamp) | 
               del(.metadata.resourceVersion) | 
               del(.metadata.namespace) | 
               del(.metadata.uid) | 
               del(.metadata.ownerReferences) |
               del(.metadata.managedFields) |
               del(.metadata.labels)
-          ' | \
-          $OC apply -n $TO_NAMESPACE -f - || error "Failed to copy over $resourceType $resourceName."
-      
+          ' tmp-resource.yaml || error "Could not update tmp-resource.yaml"
+      # delete storageclass field from common-service CR
+      if [[ $resourceType == "commonservice" && $storageClass_exist == "true" ]]; then 
+        echo "Deleting storageClass field from commonservice CR"
+        $YQ -i 'del(.spec.storageClass)' tmp-resource.yaml
+      fi
+      $OC apply -n $TO_NAMESPACE -f tmp-resource.yaml || error "Failed to copy over $resourceType $resourceName."
       # Check if the resource is created in TO_NAMESPACE
       check_copied_resource $resourceType $newResourceName $TO_NAMESPACE
     else
       warning "Resource $resourceType $resourceName not found and not migrated from $FROM_NAMESPACE to $TO_NAMESPACE"
     fi
+
+    rm tmp-resource.yaml
 }
 
 function check_copied_resource() {