Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] S3 creds are printed to the logs #1100

Open
1 of 2 tasks
revit13 opened this issue Mar 5, 2025 · 0 comments
Open
1 of 2 tasks

[Bug] S3 creds are printed to the logs #1100

revit13 opened this issue Mar 5, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@revit13
Copy link
Collaborator

revit13 commented Mar 5, 2025

Search before asking

  • I searched the issues and found no similar issues.

Component

KFP workflows, Transforms/Other

What happened + What you expected to happen

The s3 creds are printed to the logs:

23:32:13 INFO - request to execute: python -m dpk_lang_id.ray.transform --data_max_files=-1 --data_num_samples=-1 --data_s3_config="{'input_folder': 'test/lang_id/input/', 'output_folder': 'test/lang_id/output/'}" --lang_id_content_column_name="text" --lang_id_model_kind="fasttext" --lang_id_model_url="facebook/fasttext-language-identification" --lang_id_output_lang_column_name="lang" --lang_id_output_score_column_name="score" --runtime_code_location="{'commit_hash': '12345', 'github': 'github', 'path': 'path'}" --runtime_job_id="c9dd2933-b05b-4b3d-81fe-cf9af770eb91" --runtime_num_workers="2" --runtime_pipeline_id="pipeline_id" --runtime_worker_options="{'num_cpus': 0.8}" --data_s3_cred="{'access_key': 'minio', 'secret_key': 'minio123', 'url': '
http://minio-service.kubeflow.svc.cluster.local:9000/
'}"

Reproduction script

cd transforms/language/lang_id/ and run make workflow-test command

Anything else

No response

OS

Ubuntu

Python

Other, 3.11.x

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@revit13 revit13 added the bug Something isn't working label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant