Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wrong/ambiguous explanation in the ededup README file #1086

Open
1 of 2 tasks
roytman opened this issue Mar 2, 2025 · 1 comment
Open
1 of 2 tasks

[Bug] Wrong/ambiguous explanation in the ededup README file #1086

roytman opened this issue Mar 2, 2025 · 1 comment
Assignees
Labels
bug Something isn't working sprint-Mar-7

Comments

@roytman
Copy link
Member

roytman commented Mar 2, 2025

Search before asking

  • I searched the issues and found no similar issues.

Component

Transforms/universal/ededup

What happened + What you expected to happen

The README file says,
Column specified by the document_id_column configuration argument int64 Column that stores document ID

Documents have two IDs, integer and has (string), ededup uses the second one.

Reproduction script

try to run the transformer and point to the int IDs column.

Anything else

No response

OS

Ubuntu, Red Hat Enterprise Linux (RHEL)

Python

3.11.x

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@roytman roytman added the bug Something isn't working label Mar 2, 2025
@shahrokhDaijavad
Copy link
Member

@cmadam Does this mean the only change needed in the README file is to change int64 to str in the Data Type column of the first table in the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sprint-Mar-7
Projects
None yet
Development

No branches or pull requests

4 participants