Moar changes

Author: djfitzgerald

install.py

@@ -449,9 +449,18 @@ def register_file(system):
         # as cp037 (IBM-037)
         if is_rw_with_EBCDIC(file):
             encoding = "cp1047"
-            newline = "\x85"
             left_bracket = "\xDD"
             right_bracket = "\xA8"
+            
+            # newline must be '\x85' when using IzODA and Rocket Pythons, but
+            # '\n' when using IBM Python.  Since we can only easily support one
+            # path at the moment, we're going to support IBM Python since it
+            # works better.  This code is only needed to run when .bashrc and/or
+            # .bash_profile is untagged; if the files are already tagged ASCII
+            # or EBCDIC, then everything works fine on both IzODA/Rocket IBM
+            # Pythons.  We will document this in known-issues.md and call it
+            # a day.
+            #newline = "\x85"
 
         print(f"registering {file}")
         append_to_file(file, "# CLAI setup"+newline, encoding)

known-issues.md

@@ -57,4 +57,6 @@ instructions in [README.md](README.md), or you can run:
 
 #### IzODA Python 3.6
 
++ In order for install/uninstall to work properly your `.bashrc` and
+  `.bash_profile` files must be tagged either ISO8859-1 or IBM-1047 beforehand
 + The `zmsgcode` plugin fails to work due to an SSL validation failure

test_integration/test_install.py

@@ -23,7 +23,7 @@
 )
 
 INSTALL_CORRECTLY_MESSAGE = "CLAI has been installed correctly, you will need to restart your shell."
-UNINSTALL_CORRECTLY_MESSAGE = "CLAI has been uninstalled correctly, you need restart your shell."
+UNINSTALL_CORRECTLY_MESSAGE = "CLAI has been uninstalled correctly, you will need to restart your shell."
 
 
 def test_install_should_finish_correctly(my_clai):

uninstall.py

@@ -186,7 +186,7 @@ def execute(args):
     remove_setup_file(get_setup_file())
     remove_setup_register()
 
-    print_complete("CLAI has been uninstalled correctly, you need restart your shell.")
+    print_complete("CLAI has been uninstalled correctly, you will need to restart your shell.")
 
     return 0