Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure activity identifiers cannot contain white space #1657

Open
2 tasks
emmajclegg opened this issue Jan 7, 2025 · 1 comment
Open
2 tasks

Ensure activity identifiers cannot contain white space #1657

emmajclegg opened this issue Jan 7, 2025 · 1 comment
Labels
Bug Inconsistencies or issues which will cause an issue or problem ODS Issue initiated by ODS

Comments

@emmajclegg
Copy link
Collaborator

emmajclegg commented Jan 7, 2025

IATI Publisher currently allows users to enter an activity identifier that contains white space:
image

This is then used to generate the iati-identifier field:
image

According to IATI Standard guidance, activity identifiers should not start or end with spaces or new lines. We also know identifiers can be hard to process if they contain spaces or symbols.

Can we:

  • add data validation to the activity-identifier data entry form field to prevent a user from saving a string that contains any white space or special characters (apart from hyphens "-" )
  • (optional) decide whether to apply the same rules to NEW activities that are being imported into IATI Publisher. We do not want to block the download and re-upload of existing activities that break these rules
@emmajclegg emmajclegg added Bug Inconsistencies or issues which will cause an issue or problem ODS Issue initiated by ODS labels Jan 7, 2025
@stevieflow
Copy link
Collaborator

Thanks @emmajclegg

I'd also suggest that an activity identifier should avoid any use of special characters, except hyphens.

As you note, this isn't explicit in the IATI guidance, but we are more aware of what makes a good identifier, and using characters that might break URIs could be helpful: eg any of: \ / !"£$%^&*()

use case: you input an identifier 1234/5678/910

An application that then uses this identifier could "break", by falsely interpreting these characters as instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Inconsistencies or issues which will cause an issue or problem ODS Issue initiated by ODS
Projects
None yet
Development

No branches or pull requests

2 participants