Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: filter_radius is not used anywhere #971

Open
Bebra777228 opened this issue Feb 10, 2025 · 1 comment
Open

[Feature]: filter_radius is not used anywhere #971

Bebra777228 opened this issue Feb 10, 2025 · 1 comment
Labels
enhancement New feature or request feature

Comments

@Bebra777228
Copy link
Contributor

Bebra777228 commented Feb 10, 2025

I noticed that in the code, the filter_radius parameter is only passed but not used. In the RVC repository, this parameter was only necessary for Harvest, but you don't have it. In this regard, the question arises: wouldn't it be better to remove this parameter or add some logic for it so that it isn't just written there for no reason?

filter_radius,

or am I wrong?

@Bebra777228 Bebra777228 added enhancement New feature or request feature labels Feb 10, 2025
@blaisewf
Copy link
Member

can be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

No branches or pull requests

2 participants