Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue while downloading model using huggingface model path #9

Open
framolfese opened this issue Dec 27, 2024 · 1 comment
Open

Issue while downloading model using huggingface model path #9

framolfese opened this issue Dec 27, 2024 · 1 comment

Comments

@framolfese
Copy link

I'd like to notify you that, from line 74 to 78 of the answer_extractor.py file, the model is download on a local directory which does not match the standard huggingface .cache path. This causes an useless structural overhead. Moreover, the files are saved in .bin format, which also require more disk space. Note that the AutoModelForCausalLM.from_pretrained() method already takes into account the case in which the model is a local path or an huggingface model id, therefore there is no need to implement these 4 lines of code. You can safely remove them and allow HF to handle the download / load of your models.

@Duguce
Copy link
Collaborator

Duguce commented Dec 30, 2024

Thank you for your suggestion! The reason we specifically designed the local directory logic was to facilitate the unified management of downloaded model files. However, the issues and suggestions you mentioned are indeed valid, and we will consider further optimizing this part of the logic to enhance its robustness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants