Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

153 - Upload a picture into a document #184

Closed
wants to merge 3 commits into from
Closed

153 - Upload a picture into a document #184

wants to merge 3 commits into from

Conversation

raphaelweis
Copy link
Contributor

@raphaelweis raphaelweis commented May 19, 2024 •
edited
Loading

We, Raphaël WEIS, Fabien PETIT, Barnabé PETIT, Louis DUHALBERRUER, Martin GANDON, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

Closes #153.

@raphaelweis raphaelweis force-pushed the feature-153 branch 6 times, most recently from cb89e5b to 60edf86 Compare May 29, 2024 13:54
@raphaelweis raphaelweis force-pushed the feature-153 branch 2 times, most recently from 20153ca to 5dc0127 Compare June 5, 2024 14:05
@raphaelweis raphaelweis marked this pull request as ready for review June 5, 2024 22:47
@raphaelweis raphaelweis requested a review from benel as a code owner June 5, 2024 22:48
@raphaelweis
Copy link
Contributor Author

raphaelweis commented Jun 5, 2024 •
edited
Loading

The implementation for uploading an image is working correctly, and the associated test passes correctly.
I think some tests are broken following some css adjustments I had to make, I will work on fixing those on friday.
Additionally, this branch hasn't been updated for 3 weeks, resulting in a merge conflict with main that will need to be addressed.

@raphaelweis raphaelweis force-pushed the feature-153 branch 7 times, most recently from 4963184 to 3cc363d Compare June 7, 2024 19:58
@benel benel changed the title Upload a picture into a document (see #153). 153 - Upload a picture into a document Jun 8, 2024
benel
benel approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@benel benel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @raphaelweis, @nitram35, @petitfa1, @Barnabepetit, feature 153 ("Upload...") is ready to be integrated! 🎉

benel
benel requested changes Jun 8, 2024
View reviewed changes
Copy link
Member

@benel benel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errm. Maybe I wrote too fast...
Could your please fix the CSS rules that broke the glose metadata layout?

Main branch:
Capture d’écran 2024-06-08 à 12 07 30

Feature-153 branch:
Capture d’écran 2024-06-08 à 12 06 36

@raphaelweis raphaelweis force-pushed the feature-153 branch 2 times, most recently from 750582a to bf6c34f Compare June 12, 2024 08:48
@raphaelweis raphaelweis force-pushed the feature-153 branch 2 times, most recently from 33843a1 to b1eac14 Compare June 12, 2024 09:31
@raphaelweis raphaelweis requested a review from benel June 12, 2024 09:59
@raphaelweis
Copy link
Contributor Author

Turns out I went too fast after refactoring my CSS file. I have added an import for my css file at the top of PassageMarginMenu and I've updated the CSS to use the class content instead of editable to prevent the changes from affecting the glose metadata layout.

Additionally, I've updated the branch with the latest commits on main, and I've changed the placeholder for the alt text of new images from the image name to <IMAGE DESCRIPTION>.

@benel
Copy link
Member

benel commented Jun 19, 2024

Integrated as 597670f 🎉

Well done @raphaelweis @nitram35 @petitfa1 @Barnabepetit!!!

Thank you for your contribution!

@benel benel closed this Jun 19, 2024
@benel benel deleted the feature-153 branch July 15, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benel benel Awaiting requested review from benel benel is a code owner

Assignees

@louisduhalberruer louisduhalberruer

@nitram35 nitram35

@raphaelweis raphaelweis

@petitfa1 petitfa1

@Barnabepetit Barnabepetit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload a picture into a document
6 participants
@raphaelweis @benel @louisduhalberruer @nitram35 @petitfa1 @Barnabepetit