Removing remaining database triggers #2230
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes #2228
Fixes #2231
Changes proposed
Moved the logic to update
run_schemas
anddataset_schemas
into Horreum logic and as a consequence I removed the following entities:Triggers:
Functions:
I kept the procedure
update_run_schemas
in the db as it is always called by the Horreum directly.Additionally with commit 714223f I removed the remaining triggers on
Run
table:With commit d18fcc7 I also removed all triggers associated to the
label
table:And related functions. Moreover I also deleted the
label_recalc_queue
table as no longer used.Preconditions
Check List (Check all the applicable boxes)