New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code paths for rooms that use custom GLBs should be DRY'd up #206

Open

brianpeiris opened this issue Jul 26, 2019 · 0 comments

Labels

Contributor

brianpeiris commented Jul 26, 2019

We have separate code paths for rooms with Scenes vs rooms that use custom GLBs.
E.g. https://github.com/mozilla/reticulum/blob/master/lib/ret_web/views/api/v1/hub_view.ex.
This can lead to bugs since we often have to maintain similar code for both paths, but things get missed.

brianpeiris added the tech debt label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment