Fix HMR in React Framework #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 81960d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for houdinigraphql canceled.
|
✅ Deploy Preview for houdini-docs-next canceled.
|
Deploying with
|
| Latest commit: |
81960d4
|
| Status: | 🚫 Build failed. |
Closed
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewires the adapter logic to not force vite and
@whatwg-node/serverto work together. Instead I added another layer between the two so that we can use the generic adapter in prod but use something more vite-compatible in dev.Along the way, I also made sure that the cloudflare deployment story ironed out. There was an issue caused by fragments (i wasn't compiling user's files down to something appropriate for the server). Now, there is an
ssrbuild that gets generated to use on the server (this is wherehoudini/adapterultimately points to)