Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginated Fragment Store in SinglePage mode does not refresh its data #1142

Open
vboulaye opened this issue Aug 11, 2023 · 0 comments · May be fixed by #1145
Open

Paginated Fragment Store in SinglePage mode does not refresh its data #1142

vboulaye opened this issue Aug 11, 2023 · 0 comments · May be fixed by #1145
Labels
Bug Something isn't working like it should

Comments

@vboulaye
Copy link

Describe the bug

Hi,
I am trying to use @paginate in a paginatedFragment()inSinglePage` mode (with a Relay connection + cursor), but the store is never updated with the next page data after I call loadNextPage()

When I switch to the Infinite mode the new nodes are added to the store.

In SinglePage mode, even though I see the graphql request for the next page fired from the browser and the next nodes are returned, the new nodes in the returned data is never set in the store..

I managed to reproduce the problem by forking the fragment/forward-cursor e2e test.

Severity

serious, but I can work around it

Steps to Reproduce the Bug

inside a paginatedFragment, set the @paginate mode to SinglePage
call loadNextPage(), this triggers the graphql call to get the next set of nodes
the paginated fragment store data is never updated

Reproduction

https://github.com/vboulaye/houdini/tree/paginated-fragment-single-page/e2e/kit/src/routes/pagination/fragment/forward-cursor-single-page

@jycouet jycouet linked a pull request Aug 21, 2023 that will close this issue
5 tasks
@AlecAivazis AlecAivazis added the Bug Something isn't working like it should label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working like it should
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants