Fix bug when dash is present in react route (#1236)

HoudiniGraphql · Dec 3, 2023 · 1ff715b · 1ff715b
1 parent b7d5241
commit 1ff715b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/curvy-apes-fry.md b/.changeset/curvy-apes-fry.md
@@ -0,0 +1,5 @@
+---
+'houdini-react': patch
+---
+
+Fix bug when dash present in route name
diff --git a/e2e/react/src/routes/hello/+page.gql → e2e/react/src/routes/hello-world/+page.gql b/e2e/react/src/routes/hello/+page.gql → e2e/react/src/routes/hello-world/+page.gql
diff --git a/e2e/react/src/routes/hello/+page.tsx → e2e/react/src/routes/hello-world/+page.tsx b/e2e/react/src/routes/hello/+page.tsx → e2e/react/src/routes/hello-world/+page.tsx
diff --git a/packages/houdini/src/lib/router/conventions.ts b/packages/houdini/src/lib/router/conventions.ts
@@ -98,7 +98,7 @@ export function page_id(path: string) {
 	if (path.endsWith('/') && path.length > 1) {
 		path = path.substring(0, path.length - 1)
 	}
-	const special_chars = ['/', ']', '[', '(', ')']
+	const special_chars = ['/', ']', '[', '(', ')', '-']
 	const mask = '_'
 
 	let copy = ''