Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify_checkpoint fails for conf file that imports another conf file #1256

Open
hnyu opened this issue Mar 29, 2022 · 3 comments
Open

verify_checkpoint fails for conf file that imports another conf file #1256

hnyu opened this issue Mar 29, 2022 · 3 comments

Comments

@hnyu
Copy link
Collaborator

hnyu commented Mar 29, 2022

def _create_algorithm_and_env(root_dir):
    """Create algorithm and env from config file."""
    alf.reset_configs()
    conf_file = common.get_conf_file()
    try:
        common.parse_conf_file(conf_file)

When creating the algorithm2, we use runpy to run the conf file again. However, if the conf file imports another base conf file, then runpy won't reload the module. As we've already reset all alf configs, this will make the configs in the base conf file not properly configured.

@hnyu
Copy link
Collaborator Author

hnyu commented Mar 29, 2022

@emailweixu I didn't find an easy way to force runpy reloading the modules in the config file. Any idea?

@emailweixu
Copy link
Contributor

I had a fix for verify_checkpoint in my local branch a while ago.

@emailweixu
Copy link
Contributor

My change #1257 does not fix your problem. It just give a better error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants