Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the auto-labeler for issue tags, priority levels in our issue templates #327

Merged
merged 10 commits into from
Oct 14, 2024

Conversation

emprzy
Copy link
Collaborator

@emprzy emprzy commented Oct 2, 2024

Describe your changes.

In this pull request I deleted the YAML file that configured the auto-labeler for issue tags and priority levels, as well as the dropdowns within the actual issue templates where users select labels and priority.

What does your pull request address? Tag relevant issues.

This pull request addresses GH-319. Since we determined that the auto-labeler was problematic, it's getting the boot! Also mentioned in this issue are the actual issue tags themselves. I can't make a pull request for the changes I'm going to make to those (because issue labels only exist at the repo level). But I will be deleting three of the tags (help wanted, invalid, question, revisit ASAP), and making definitions a little bit more clear for a couple others.

Thanks y'all!

emprzy added 3 commits October 2, 2024 11:24
Deleting the auto-labeler configuration file
Removing dropdowns for issue labels and priority labels.
Removing dropdowns for issue labels and priority labels.
@TimothyWillard
Copy link
Contributor

I'm glad the auto-labeler is getting the boot, but why are the label/priority drop downs being removed as well? I like them because they strongly encourage issue reporters to tag their issues in a way that makes them quick to get context and sort on.

@emprzy
Copy link
Collaborator Author

emprzy commented Oct 2, 2024

I'm glad the auto-labeler is getting the boot, but why are the label/priority drop downs being removed as well? I like them because they strongly encourage issue reporters to tag their issues in a way that makes them quick to get context and sort on.

Oh I see. I was under the impression you were anti the drop downs because they were a bit redundant, but I agree that they offer a (positive) certain degree of mandatory-ness to labeling issues, even if selecting from the drop down doesn't actually label the issue as such.

I'll bring them back and update them!

emprzy added 2 commits October 2, 2024 12:21
Bringing back the drop downs! 🥳
Bringing back the drop downs! 🥳
jcblemai
jcblemai previously approved these changes Oct 2, 2024
emprzy added 3 commits October 2, 2024 15:26
Adding a `flepiconfig` label (in addition to just `config`)
Adding a `flepiconfig` label (in addition to just `config`)
@emprzy
Copy link
Collaborator Author

emprzy commented Oct 7, 2024

This is ready to be merged, if you approve @TimothyWillard @jcblemai

Copy link
Contributor

@TimothyWillard TimothyWillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns are addressed here so I'll go ahead and approve. However, not sure if this line of questioning was resolved: #327 (comment). @jcblemai Do you have a preference for adding all of the package specific tags in this PR or in a followup? Might be best to add the R package specific tags with a r- prefix so r-flepiconfig, r-flepicommon, and r-inference?

@emprzy
Copy link
Collaborator Author

emprzy commented Oct 7, 2024

My concerns are addressed here so I'll go ahead and approve. However, not sure if this line of questioning was resolved: #327 (comment). @jcblemai Do you have a preference for adding all of the package specific tags in this PR or in a followup? Might be best to add the R package specific tags with a r- prefix so r-flepiconfig, r-flepicommon, and r-inference?

Oh, this is a good question indded

@emprzy
Copy link
Collaborator Author

emprzy commented Oct 14, 2024

Would love to get this merged ASAP to fix the issue/PR templates. The conversation surrounding what labels we have can be ongoing and dynamic, independent of this.

Copy link
Member

@shauntruelove shauntruelove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Merge it!

@emprzy emprzy merged commit 8ea57b4 into main Oct 14, 2024
1 check passed
@emprzy emprzy deleted the fixing-issue-labels branch October 14, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants