Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libreoffice-still 24.8.4 #200053

Merged
merged 2 commits into from
Jan 30, 2025
Merged

libreoffice-still 24.8.4 #200053

merged 2 commits into from
Jan 30, 2025

Conversation

chenrui333
Copy link
Member

Created by brew bump


Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Jan 30, 2025
@khipp khipp enabled auto-merge January 30, 2025 14:59
@khipp khipp merged commit 3d31782 into master Jan 30, 2025
11 checks passed
@khipp khipp deleted the bump-libreoffice-still-24.8.4 branch January 30, 2025 15:03
@samford
Copy link
Member

samford commented Feb 1, 2025

@chenrui333 If I'm not mistaken, this shouldn't have been updated to 24.8.4 (same for libreoffice-still-language-pack). The livecheck block returns 24.2.7 as the newest version, as there are two versions in the stable directory (24.8.4 and 24.2.7) and the "still" version is the lower one. The newest version is what the main libreoffice cask uses.

Did you get the 24.8.4 version from livecheck or did you manually identify the version and update this?

@khipp
Copy link
Member

khipp commented Feb 1, 2025

@samford This is likely related to #200079. It seems that new versions were available for a short period of time.

@samford
Copy link
Member

samford commented Feb 1, 2025

@khipp Ahh, thanks for the reference. If upstream uploaded the versions but didn't announce them, livecheck would have still picked them up.

Though I'm not overly fond of matching versions from loose text, it may be better to check the release notes page, as that would ensure that we only update after upstream treats a version as released. I'll look around to see if there are other alternatives but I can at least say that the download page only lists the newest version (not the "previous release"/still version).

Related PRs: #200280, #200281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump automerge-skip bump-cask-pr PR was created using `brew bump-cask-pr`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants