Skip to content
This repository has been archived by the owner on Feb 3, 2025. It is now read-only.

What's the problem with validator.optional and a default string? #221

Open
hf-kklein opened this issue Jan 19, 2023 · 0 comments
Open

What's the problem with validator.optional and a default string? #221

hf-kklein opened this issue Jan 19, 2023 · 0 comments

Comments

@hf-kklein
Copy link
Contributor

hf-kklein commented Jan 19, 2023 •
edited
Loading

src\maus\models\anwendungshandbuch.py:156: error: Argument "validator" to "field" has incompatible type "Callable[[Any, Attribute[Optional[str]], Optional[str]], Any]"; expected "Union[Callable[[Any, Attribute[str], str], Any], Sequence[Callable[[Any, Attribute[str], str], Any]], None]" [arg-type]
hf-kklein added a commit that referenced this issue Jan 19, 2023
@hf-kklein
add todo comment / link to issue
3ad636a 
#221
hf-kklein added a commit that referenced this issue Jan 23, 2023
@hf-kklein @hf-krechan
🆕 Alles Neu: maus v0.3.1 (#189)
ab45ff6 
* make `SegmentGroupHierarchy` frozen

* wip

* wip

* format

* more wip

* ➕ install `more_itertools`

* Check`FlatAnwendungshandbuch`: Nearly all lines should have a SG

* formatting

* merge

* no linting warning is navigation

* navigation ok

* wip

* improve navigation (add data_element_id)

* wip

* wippi wip

* closer

* black wip

* sublocation

* wip

* wip

* Auto stash before checking out "origin/main"

* wip

* wip

* black

nah dran

* ancestor foo

* wip

* Add "distance" calculation for pairs of `AhbLocations`

* wio

* remove trailing whitespace

* so close.

* add todo for next working day: sg4/sg5 trnasition

* ✨Implement `sg_is_hierarchically_below` to easily spot relations in SGHs

* wip

* opk ok ok ok...... 🥳


okok, bisschen aufgeräumt

* okokok

* wiipi

* let's wait to put it all together...

* dirty workarounds

* wip

* wip

* wip

* Introduce maus-version in metadata

* wip

* wip

* wio

* wip

* linter

* wip wip

* 🎅wip

* 🔥 Drop support for FV2110


isort .

* wp

* wipii

Hochfrequenz/edifact-templates#236

* drop more fv2110 support

* wip

* wip

* wip

* wip

* shorten

* better

* wip

* fix mypy

* us emain

* use sdä commit

* 🔥 remove unnecessary `del`s

* small pylint fixes

* restructure shit

* bad wip

* Revert "🔥 remove unnecessary `del`s"

This reverts commit f585575.

* remove unused import

* Revert "Revert "🔥 remove unnecessary `del`s""

This reverts commit ddb86c8.

* linting error

* fix schlendrian issue from last year

* group them imports


so.

* fix/ignore mypy/pylint warnings

* isort .

* black .

* immerhin

* drop more fv2110

* readability of error message

* besser

* readably error message

* bababamamam

* bam

* ok ok ok

* wuwuwuwuwuwuw

* templates foo

* black

* wup

* call it a day

* better than nothing

* wip

* stricter validation of FlatAhb names

* besser

* edimetadata

* Auto stash before merge of "ich_verbrenn_mein_studio" and "origin/main"

* use flat ahb main

* maus 0303

* so?

* add magic assertions

* Don't require tests for now

todo: revert

* fix naming error

* drop old test

* besser

* 🔥 Drop Support for 11120, 11124, 11127, 11123, 11218, 11219

* Revert "Don't require tests for now"

This reverts commit 346f89e.

* na gut

.

* fix naming error

* Update src/maus/mig_ahb_matching.py

Co-authored-by: kevin <[email protected]>

* fix type check (discriminator may be none)

* 🔥Drop support for 11219, 11218, 11123, 11119, 11117, 11127, 11124, 11120

* remove workaround fixed by kohlrahbi

* update comment

* ja, es ist schlimm

* re-enable throwing meaningful error message

* re-enable throwing meaningful error messages

* re-add validator

* remove another disable fixme

* add comment

* add todo comment / link to issue

#221

* add a looooong comment

Co-authored-by: kevin <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hf-kklein