Skip to content
This repository has been archived by the owner on Feb 3, 2025. It is now read-only.

Harmonize DataElementValueType and DataElementDataType #138

Open
hf-kklein opened this issue Aug 29, 2022 · 0 comments
Open

Harmonize DataElementValueType and DataElementDataType #138

hf-kklein opened this issue Aug 29, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@hf-kklein
Copy link
Contributor

hf-kklein commented Aug 29, 2022

Downstream services (namely ahbicht) now need to decide whether to use the name DataType or ValueType. This confusion/ambiguity is unnecessary.

Ideas

  • From the DataElements perspective the name "value type" seems more appropriate imo, because it characterizes the data elements value.
  • For (also non python) downstream dependents it is easier if we don't change the attribute name but the type name (because this doesn't affect the json serialization)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants