-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain yourself #11
Comments
Thanks @tomturton, The reason In this example, there is also no Thank you for the feedback. I wonder whether writing the explanations as comments in the CSS itself would suffice? |
Thanks for your swift answer, Heydon. I might have confused you a bit with the button example. I was actually talking about normal This element would still trigger the If you are going to make it look like a button, make it a button, dammit! warning. The point I was trying to make was that hyperlinks should nearly always use the I would agree that buttons that submit a form or trigger an event on a page should be But we digress. Regarding explanations, I think the most sensible place would be in the GitHub Cheers, |
Hi, Cheers. |
@tomturton Hey! Yeah, I got rid of that and made some other improvements for a merge with a11y.css. See 744d39f Cheers. |
Classy. That's much more forgiving. Any chance of explaining reasons for the warning messages in I found your rather good Smashing Magazine article, which sums your rules up nicely, but it would be more useful to have an up-to-date version directly associated with the project. Maybe in the meantime you could link to your article from
|
Hi Heydon,
I love this and have had a lot of fun using it on my website and my competitors (yes, I get a real kick out of seeing how many HTML fuck-ups they've made)
What I really think the project needs however is some explanation as to why some things are bad.
I imagine where a rule isn't considered best practices, you still have some very logical reasons, but it would be useful to know them.
For example, I am quite puzzled about why I often see If you are going to make it look like a button, make it a button, dammit! on
<a class="button">
elements. These 'buttons' are hyperlinks and should work without JavaScript and be seen as links by search engines and screen readers. Does that mean they should not look like buttons? I think that's a very harsh limitation to a designer.Thanks for your time and contributions to the web community.
Tom
The text was updated successfully, but these errors were encountered: