Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a category keeps it selected #4266

Open
arielj opened this issue Jan 11, 2025 · 1 comment
Open

Deleting a category keeps it selected #4266

arielj opened this issue Jan 11, 2025 · 1 comment
Labels
bug:confirmed Something isn't working. good first issue Good for newcomers.

Comments

@arielj
Copy link
Collaborator

arielj commented Jan 11, 2025

Describe the bug

When you delete a category that was selected, Heroic thinks it's still selected and applies it. It shouldn't be considered at all and removed from all places.

Add logs

Not relevant

Steps to reproduce

  1. Create a category (let's call it "ASD")
  2. Don't add any games to it so the issue is more obvious
  3. Click to ONLY filter by category "ASD" (no games should be displayed)
  4. Click Manage Categories
  5. Delete category "ASD"
  6. Heroic is still "filtering by ASD" though there's no indication, and heroic still shows no games

The user then has to go and manually reset categories or select/deselect other categories for things to get updated.

Expected behavior

Deleting a category should remove if from the list of categories and also from the list of categories being selected, so filters are updated too.

Screenshots

No response

Heroic Version

Latest Stable

System Information

Not relevant

Additional information

No response

@arielj arielj added bug:confirmed Something isn't working. good first issue Good for newcomers. labels Jan 11, 2025
@Nirpendra09
Copy link

@arielj can i take up this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed Something isn't working. good first issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

2 participants