Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable macOS universal build #4164

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LenaWil
Copy link

@LenaWil LenaWil commented Dec 7, 2024

Creates a build that runs on both architectures.

I feel like this should break things but small tests I did it seems to work?


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC
Copy link
Collaborator

Excuse my inexperience, but do we still want to keep the separate x86_64 and arm64 builds? Wouldn't the universal build alone suffice?

@LenaWil
Copy link
Author

LenaWil commented Dec 15, 2024

Honestly could be, I don’t really care, but some people do like the smaller size and I have no idea how the auto update works.
I don’t know what y’all’s opinions on universal builds are and why they weren’t enabled; figured the easiest way to get an answer would be to send a pull request. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants