Heroic not recognising game process has quit - which is inhibiting gnome session lock

[blipk]

Describe the bug

If I quit the game (Rocket League) via gnome-shells dash icon (right clicking and "quit") then Heroic does not recognise the game has quit, which is preventing the desktop from auto-locking.

Sometimes the process can still be seen in process manager, sometimes it cannot, but there is no icon on the dash.

Heroic could maybe clean up processes better? Or is this related to the game and it's poorly dealing with the quit signal?

Screenshots are AFTER I have quit from the dash.

Add logs

(12:26:03) INFO:    [Legendary]:        Legendary location: /opt/Heroic/resources/app.asar.unpacked/build/bin/x64/linux/legendary
(12:26:03) INFO:    [Gog]:              GOGDL location: /opt/Heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl
(12:26:03) INFO:    [Connection]:       Connectivity: check-online
(12:26:03) INFO:    [Connection]:       Pinging external endpoints
(12:26:03) INFO:    [Gog]:              Checking for existing gog manifests
(12:26:04) WARNING: [Backend]:          Protocol already registered.
(12:26:04) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=/home/user/.config/heroic/legendaryConfig/legendary /opt/Heroic/resources/app.asar.unpacked/build/bin/x64/linux/legendary --version
(12:26:04) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/user/.config/heroic/gogdlConfig /opt/Heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/user/.config/heroic/gog_store/auth.json --version
(12:26:04) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=/home/user/.config/heroic/nile_config /opt/Heroic/resources/app.asar.unpacked/build/bin/x64/linux/nile --version
(12:26:04) INFO:    [Connection]:       Connectivity: online
(12:26:04) ERROR:   [Gog]:              Unable to syncQueued playtime, userData not present
(12:26:04) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/user/.config/heroic/gogdlConfig /opt/Heroic/resources/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/user/.config/heroic/gog_store/auth.json auth
(12:26:04) INFO:    [Backend]:          AreWeAntiCheatYet data downloaded
(12:26:05) INFO:    [Backend]:          
System Information:
CPU: 4x AMD Ryzen 3 4300U with Radeon Graphics
Memory: 33.04 GB (used: 4.08 GB)
GPUs:
  GPU 0:
    Name: NVIDIA Corporation GP107 [GeForce GTX 1050 Ti]
    IDs: D=1c82 V=10de SD=3512 SV=1028
    Driver: nvidia
  GPU 1:
    Name: Advanced Micro Devices, Inc. [AMD/ATI] Renoir [Radeon Vega Series / Radeon Vega Mobile Series]
    IDs: D=1636 V=1002 SD=87e7 SV=1043
    Driver: amdgpu
OS: Manjaro Linux 6.6.46-1-MANJARO (linux)

The current system is not a Steam Deck
We are not running inside a Flatpak container

Software Versions:
  Heroic: 2.15.1 Emeth
  Legendary: 0.20.35 Lowlife (Heroic)
  gogdl: 1.1.1
  comet: comet 0.1.2

  Nile: 1.1.1 Will A. Zeppeli

(12:26:05) INFO:    [Frontend]:         Refreshing undefined Library
(12:26:05) WARNING: [Backend]:          refresh not implemented on Sideload Library Manager
(12:26:05) INFO:    [Legendary]:        Refreshing library...
(12:26:05) INFO:    [Legendary]:        Refreshing Epic Games...
(12:26:05) INFO:    [Backend]:          Frontend Ready
(12:26:05) INFO:    [Backend]:          Checking for new Heroic Updates
(12:26:05) INFO:    [Backend]:          Checking for current version changelog
(12:26:05) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=/home/user/.config/heroic/legendaryConfig/legendary /opt/Heroic/resources/app.asar.unpacked/build/bin/x64/linux/legendary list --third-party
(12:26:06) INFO:    [Winetricks]:       Downloading Winetricks
(12:26:08) INFO:    [Legendary]:        Game list updated, got 3 games & DLCs
(12:26:08) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(12:26:08) INFO:    [Legendary]:        Checking for game updates: LEGENDARY_CONFIG_PATH=/home/user/.config/heroic/legendaryConfig/legendary /opt/Heroic/resources/app.asar.unpacked/build/bin/x64/linux/legendary list --third-party
(12:26:08) INFO:    [WineDownloader]:   Updating wine versions info
(12:26:08) INFO:    [WineDownloader]:   Fetching upstream information...
(12:26:10) INFO:    [WineDownloader]:   wine versions updated
(12:26:10) INFO:    [Backend]:          Starting the Download Queue
(12:26:11) INFO:    [Legendary]:        Found 0 games to update
(12:26:35) INFO:    [Backend]:          Launching Rocket League® (Sugar)
(12:26:35) INFO:    [Backend]:          Preventing display from sleep
(12:26:35) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton 8.0
(12:26:35) INFO:    [Backend]:          Preventing machine to sleep
(12:26:35) INFO:    [Backend]:          Using Steam sniper Runtime
(12:26:35) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton 8.0
(12:26:35) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton 8.0
(12:26:35) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton 8.0
(12:26:35) DEBUG:   [Backend]:          Running Wine command: run wineboot --init
(12:26:42) INFO:    [Legendary]:        Launching Rocket League®: HEROIC_APP_NAME=Sugar HEROIC_APP_RUNNER=legendary GAMEID=umu-0 HEROIC_APP_SOURCE=epic STORE=egs STEAM_COMPAT_INSTALL_PATH=/home/user/Games/Heroic/rocketleague LD_PRELOAD= STEAM_COMPAT_CLIENT_INSTALL_PATH=/home/user/.steam/steam WINEPREFIX="/home/user/Games/Heroic/Prefixes/default/Rocket League" STEAM_COMPAT_DATA_PATH="/home/user/Games/Heroic/Prefixes/default/Rocket League" PROTONPATH="/home/user/.local/share/Steam/steamapps/common/Proton 8.0" DXVK_HUD=fps WINE_FULLSCREEN_FSR=0 PROTON_DISABLE_NVAPI=1 PROTON_EAC_RUNTIME=/home/user/.config/heroic/tools/runtimes/eac_runtime PROTON_BATTLEYE_RUNTIME=/home/user/.config/heroic/tools/runtimes/battleye_runtime STEAM_COMPAT_APP_ID=0 SteamAppId=0 SteamGameId=heroic-rocketleague PROTON_LOG_DIR=/home/user LEGENDARY_CONFIG_PATH=/home/user/.config/heroic/legendaryConfig/legendary /opt/Heroic/resources/app.asar.unpacked/build/bin/x64/linux/legendary launch Sugar --no-wine --wrapper "/usr/bin/mangohud --dlsym /home/user/.local/share/Steam/steamapps/common/SteamLinuxRuntime_sniper/_v2-entry-point -- "/home/user/.local/share/Steam/steamapps/common/Proton 8.0/proton" waitforexitandrun" --language en
(12:26:42) INFO:    [Backend]:          Preventing display to sleep

Steps to reproduce

1. Minimize Rocket League
2. Right click application icon on dash and "Quit"
3. Wait....
4. Gnome session does not lock because the process remains open

Expected behavior

Game process should quit when being quit from dash.

Screenshots

Heroic Version

Latest Stable

System Information

Manjaro/Arch

Additional information

No response

[arielj]

Heroic waits until the process it started ends, if that process starts a child process and you kill the the child an the original process doesn't end we can't know that from Heroic's side, we don't have control over that.

Do you have any wine/proton process still running after you quit the game?

[arielj]

Seems like this similar to #3976 ?

[blipk]

@arielj

That is the same issue # you quoted

It seems to run in a different process dependency tree to heroic:

The issue doesn't appear to be happening as often in the latest version of heroic though (or perhaps something else in the OS and how its sending/handling the quit signal) - the srt-bwrap process tree seems to end after a while when I quit via the dash/panel now.