Skip to content

Commit 43423e3

Browse files
authored
[TECH] Remove the Devcontainer/Docker container (#3611)
1 parent 9213624 commit 43423e3

File tree

4 files changed

+0
-84
lines changed

4 files changed

+0
-84
lines changed

.devcontainer/devcontainer.json

Lines changed: 0 additions & 14 deletions
This file was deleted.

.dockerignore

Lines changed: 0 additions & 2 deletions
This file was deleted.

Dockerfile

Lines changed: 0 additions & 3 deletions
This file was deleted.

README.md

Lines changed: 0 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ Heroic is built with Web Technologies:
4444
- [Building Heroic Binaries](#building-heroic-binaries)
4545
- [Building with VS Code](#building-with-vs-code)
4646
- [Quickly testing/debugging Heroic on your own system](#quickly-testingdebugging-heroic-on-your-own-system)
47-
- [Development Using a Container](#development-using-a-container)
4847
- [Testing with Docker](#testing-with-docker)
4948
- [Sponsors](#sponsors)
5049
- [Screenshots](#screenshots)
@@ -251,70 +250,6 @@ Go to the "Run and Debug" tab of VSCode and start the "Launch Heroic (HMR & HR)"
251250

252251
Note: If you do not need the React developer tools while testing changes, you can skip their install by setting the `HEROIC_NO_REACT_DEVTOOLS` environment variable before running `yarn start` (for example with `HEROIC_NO_REACT_DEVTOOLS=1 yarn start`).
253252

254-
### Development Using a Container
255-
256-
<details>
257-
<summary>Expand</summary>
258-
259-
If you would prefer, we have a docker container defined to develop / build Heroic with (a potential reason being to avoid loading tons of dependencies on your host filesystem). There are two methods, based on whether you use VS Code.
260-
261-
**VS Code**
262-
263-
There is a `.devcontainer` directory containing a definition that VS Code will recognize for automatically opening your local Heroic directory in a container in VS Code.
264-
265-
**NOTE: this requires that you install the 'Remote - Containers' extension.**
266-
267-
1. Open the root of your local Heroic directory in VS Code.
268-
2. You should get a prompt in the bottom right to build and open the project in the dev container.
269-
3. If the above prompt does not occur, on the bottom left, there is a green icon that should be there if the remote extension is installed. Click on it, and select "Reopen in container".
270-
4. The bottom left green icon should now say: "Dev Container: Heroic Games Launcher".
271-
272-
After the container's package manager runs, open a new terminal session and you should be able to run bash commands from within the container. Any yarn dist:linux builds should also now show up on your host filesystem.
273-
274-
**Manually Building the Docker Image**
275-
276-
If you don't use VS Code or don't want it integrated with the container, you can build and run the container manually using either Docker or Podman.
277-
278-
1. From the root of your local Heroic directory, run:
279-
280-
```bash
281-
docker build -t heroicdevcontainer -f Dockerfile .
282-
```
283-
284-
2. Assuming all went well, you can now enter the container:
285-
286-
```bash
287-
docker run -it -v ./:/tmp/heroic localhost/heroicdevcontainer:latest
288-
```
289-
290-
3. The above command will mount your local Heroic dir to `/tmp/heroic` in the container (unless you used a different path).
291-
292-
```
293-
cd /tmp/heroic
294-
```
295-
296-
And you should be good to go, code and build away!
297-
298-
</details>
299-
300-
### Testing with Docker
301-
302-
It is recommended to run end to end tests with Docker so you don't alter your local config files or have your local config files interfere with the tests.
303-
304-
To run e2e tests on the unpackaged app running in dev mode.
305-
From the root of your local Heroic directory, run:
306-
307-
```bash
308-
yarn test:e2e
309-
```
310-
311-
To run e2e tests on the packaged app.
312-
From the root of your local Heroic directory, run:
313-
314-
```bash
315-
yarn test:e2ePackaged
316-
```
317-
318253
## Sponsors
319254

320255
Thanks [Weblate](https://weblate.org/en/) for hosting our translations

0 commit comments

Comments
 (0)