Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User journey #98

Closed
bjarneo opened this issue Sep 20, 2022 · 8 comments
Closed

User journey #98

bjarneo opened this issue Sep 20, 2022 · 8 comments

Comments

@bjarneo
Copy link
Member

bjarneo commented Sep 20, 2022

@luismanson
Copy link
Contributor

Hello, I saw issue #94 a few days ago and saw you the "user journey" but im not familiar with that concept. Would you consider to allow logins regardless of registration being disabled or add another setting to control this?

@d-513
Copy link

d-513 commented Sep 28, 2022

probably would be best to have an option to create an admin account with env variables, and disable upload for non admins. I don't want random people uploading shit to my server.
Also, LDAP support would be quite useful for me, is that desired? If so, I can get a quick PR going for it

@bjarneo
Copy link
Member Author

bjarneo commented Sep 29, 2022

@luismanson / @dada513

Yeah, it would be an admin dashboard where you can adjust the settings you would like for your application. That is my thoughts on this as well.

So the admin allows either anyone to register an account. Organizations. Add people manually. Or something in between here.

@dada513 Sure, feel free to create LDAP support. I think more people would have the need of that as well

@d-513
Copy link

d-513 commented Sep 30, 2022

@bjarneo I think for settings it's alright to do it like other services and just have configuration via environment variables, like HEMMLIG_ALLOW_REGISTER, makes deployment easier to be automated. But an admin panel would be useful for creating users though

@Zulgrib
Copy link

Zulgrib commented Nov 11, 2022

Where would these settings be stored? Plain files? Database? Would it automatically alter default.cjs or production.cjs? Add an additional file?

Using env variables bloats the systemd service file and may allow unix users on host to view the variable content where a configuration file or store in database is easier to restrict.

@bjarneo
Copy link
Member Author

bjarneo commented Nov 18, 2022

It will be saved to the database whenever that part is ready.

@bjarneo
Copy link
Member Author

bjarneo commented Apr 4, 2023

The database switch using sqlite has now been implemented, much thanks to @d-513. 560831d

From version 5.0.0 it makes it easier to implement features such as this. Here is a list of tickets that will now be possible:

#94
#26
#168
#24

@bjarneo
Copy link
Member Author

bjarneo commented Apr 4, 2023

#154

@bjarneo bjarneo closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants