Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Predibase Support is Lacking #2900

Open
colegottdank opened this issue Oct 28, 2024 · 3 comments · May be fixed by #2901
Open

[Bug]: Predibase Support is Lacking #2900

colegottdank opened this issue Oct 28, 2024 · 3 comments · May be fixed by #2901
Labels
bug Something isn't working Tusk Tusk will try and create a pull request

Comments

@colegottdank
Copy link
Collaborator

What happened?

Within the worker, we map to the predibase base URL. It says https://api.app.predibase.com but it should be https://serving.app.predibase.com

Also, the model and usage are returned as headers. When we grab the model out, we get from response body -> request body -> path. It should be the header first and if not exists, continue the existing flow.

For the usage, we grab from the body. We need to grab from there. Here are what they will look like:

Response Headers
info
These headers should be considered a beta feature, and are subject to change in the future.

x-total-tokens: The number of tokens in both the input prompt and the output.
x-prompt-tokens: The number of tokens in the prompt.
x-generated-tokens: The number of generated tokens.
x-total-time: The total time the request took in the inference server, in milliseconds.
x-time-per-token: The average time it took to generate each output token, in milliseconds.
x-queue-time: The time the request was in the internal inference server queue, in milliseconds.
x-model-id: predibase/Meta-Llama-3.1-8B-Instruct-dequantized (example model name)

Lastly, add docs for Predibase support. Reference other integrations we have, such as the integrations with DeepInfra, Fireworks AI.

Relevant log output

No response

Twitter / LinkedIn details

No response

@colegottdank colegottdank added bug Something isn't working Tusk Tusk will try and create a pull request labels Oct 28, 2024
Copy link
Contributor

use-tusk bot commented Oct 28, 2024

I'm working on this issue. Will comment once I have an update.

See activity logs for more info.

@use-tusk use-tusk bot linked a pull request Oct 28, 2024 that will close this issue
Copy link
Contributor

use-tusk bot commented Oct 28, 2024

I created a pull request for this issue. 🧑‍💻

Please approve and merge the PR once you've verified that the changes work. If there are nits, leave a "Request Changes" review for me. Otherwise, checkout the branch to make changes.

Copy link
Contributor

use-tusk bot commented Oct 28, 2024

You can see the changes for this task on this preview URL. Please approve and merge the PR if everything looks good! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Tusk Tusk will try and create a pull request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant