Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If app name have any space its giving Error , either add we can add snackbar popup for error(Space not allowed) or allow space in name #290

Open
vinay02022 opened this issue Jul 15, 2024 · 3 comments · May be fixed by #397
Open

If app name have any space its giving Error , either add we can add snackbar popup for error(Space not allowed) or allow space in name #290

vinay02022 opened this issue Jul 15, 2024 · 3 comments · May be fixed by #397
Assignees
@matejondov
Labels
feature New feature request

Comments

@vinay02022
Copy link

vinay02022 commented Jul 15, 2024 •
edited
Loading

image

image
image

Thanks.
@vinay02022 vinay02022 changed the title Is app name have any space its giving Error , either ad a snackbar popup for error(Space not allowed) or allow space in name If app name have any space its giving Error , either add we can add snackbar popup for error(Space not allowed) or allow space in name Jul 15, 2024
@deepakdinesh1123
Copy link
Contributor

@vinay02022 We do not want to allow space is names as the name will be used to create a folder for that app inside the project (might lead to some issues when parsing paths), we could try to convert the name if there is a space but let's keep the existing behaviour, if you are interested you can raise a PR to show a popup if the app name contains a space, please let us know.

@deepakdinesh1123 deepakdinesh1123 added the feature New feature request label Jul 16, 2024
@matejondov
Copy link

@deepakdinesh1123 Hi, I would like to work on this feature.
Do you think it would be better to show pop up after clicking the button or to show a warning message bellow the text input field and disabling the button when there is a space in the name?

@deepakdinesh1123
Copy link
Contributor

@matejondov I think it would be better to disable the button and show a warning text as it would be consistent across other forms in zango

@matejondov matejondov linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejondov matejondov

Labels
feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add validation to prevent spaces in App name input matejondov/Zango
3 participants
@vinay02022 @deepakdinesh1123 @matejondov