Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does hxnodejs cause the compiler to define the 'sys' define? #59

Open
kevinresol opened this issue Feb 22, 2016 · 8 comments
Open

Does hxnodejs cause the compiler to define the 'sys' define? #59

kevinresol opened this issue Feb 22, 2016 · 8 comments

Comments

@kevinresol
Copy link
Contributor

Or should it?

@Simn
Copy link
Member

Simn commented Feb 22, 2016

It does allow the sys package: https://github.com/HaxeFoundation/hxnodejs/blob/master/extraParams.hxml

I don't know if it can actually add -D sys because that's a reserved flag. We might have to find a solution for that.

@kevinresol
Copy link
Contributor Author

Yeah but some lib/code depends on the sys define. When the sys-related api are complete (e.g. Sys.stdout()), I think the compiler should define sys for us.

Tried -D sys and it complains that I can't set it manually.

@kevinresol
Copy link
Contributor Author

I don't know if it can actually add -D sys because that's a reserved flag. We might have to find a solution for that.

Is it possible to hardcode inside the compiler, defining sys when it sees the hxnodejs lib is included?

@nadako
Copy link
Member

nadako commented Jun 6, 2016

But hxnodejs doesn't implement full sys api (because it's impossible without dirty tricks (#64). It just implements some of it, so I don't know if it's reasonable to define sys...

@kevinresol
Copy link
Contributor Author

@nadako maybe make a checklist of them and see what we can do.

@nadako
Copy link
Member

nadako commented Jun 6, 2016

the main problem is that we can't implement synchronous API that are used in sys, like Sys.stdout().

@kevinresol
Copy link
Contributor Author

Will this work? http://stackoverflow.com/a/6471170/3212365

@nadako
Copy link
Member

nadako commented Jun 6, 2016

Hmm, I don't know. Will have to look into it, not sure if that'll work everywhere.
Thanks for the hint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants