Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remoting server side/client side #12

Open
filt3rek opened this issue Jun 27, 2019 · 3 comments
Open

Remoting server side/client side #12

filt3rek opened this issue Jun 27, 2019 · 3 comments

Comments

@filt3rek
Copy link

Hej !

When an error occurs on server side, remoting often reports me "Class not found " without any class name. I get that as response : "hxrxcy0:g" which means haxe remotin, exception, class, and 0 length string so no class name.
in order to get the real exception that occurs on server side I've changed that line :
https://github.com/HaxeFoundation/hx3compat/blob/master/std/haxe/remoting/HttpConnection.hx#L108 from : s.serializeException(e); to s.serializeException(Std.string(e));

@RealyUniqueName
Copy link
Member

This way you lose important information about exception if it happen to actually be of a valid class. E.g. if exception extends something like this: https://lib.haxe.org/p/exception/

Anyway, I'm not sure we want to fix something in hx3compat as it's supposed to be a deprecated code and users should migrate to atlernatives.

@filt3rek
Copy link
Author

Hej Aleksander,

Thanks for your answer !

Yes I'm sure you're right about loosing some infos but this exception appeared so often to me that this is the fast way I've found to fix that for my needs.
Now, I don't really agree with you that it should'nt be fixed in hx3compat : This lib is here in order to offer a retro compatibility and there are some issues that should be fixed IMHO, if not, there is not really need to have this kind of lib.
Anyway, I've forked it as many other users, but I find that's pitty.

@RealyUniqueName
Copy link
Member

Don't take me wrong, I'm ok to fix things here if you can provide a reproducible sample :)
Also PRs are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants