Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis lines are not drawn #5

Closed
XamlBrewer opened this issue Feb 12, 2022 · 12 comments
Closed

Axis lines are not drawn #5

XamlBrewer opened this issue Feb 12, 2022 · 12 comments

Comments

@XamlBrewer
Copy link

If you make the PlotAreaBorderColor transparent, then you notice that not a single axis line is drawn. Setting an AxislineColor has no effect. This applies to all types, so it is not the same issue as #4. I don't see anyone observing this in the base OxyPlot repo. Here's a screenshot from my sample repo here:

MissingAxes

@HavenDV
Copy link
Owner

HavenDV commented Feb 13, 2022

Sorry I don't understand the expected behavior in this case

I'm testing the behavior on the official WPF version:

with model.PlotAreaBorderColor = OxyColors.Transparent;
image

without model.PlotAreaBorderColor = OxyColors.Transparent;
image

Can you point me if there is a problem in these screenshots?
If so, then you need to create an issue at https://github.com/oxyplot/oxyplot to fix it on all platforms.
At the moment, I support the UWP/WinUI/Uno platforms of this library, trying to match the WPF behavior of the main library with some of my own additions (like Dark Theme support).

@HavenDV
Copy link
Owner

HavenDV commented Feb 13, 2022

But I definitely see a bug here :)
image

P.S. Fixed

@HavenDV
Copy link
Owner

HavenDV commented Feb 13, 2022

@VisualMelon please check this issue

@XamlBrewer
Copy link
Author

What I was expecting, is that there would be no border but axis lines would remain visible - as in the following screenshot from UWP:

Clustering

@HavenDV
Copy link
Owner

HavenDV commented Feb 13, 2022

Perhaps there is some configuration problem here? Because I wasn't able to achieve this behavior in WPF with any of the versions of OxyPlot.WPF.
Also, I couldn't find the AxislineColor property. What class is it in?

@XamlBrewer
Copy link
Author

It's in the OxyPlot.Axes.Axis class (oxyplot.core\2.1.0\lib\netstandard2.0\OxyPlot.dll).

This is the corresponding code from my Theming sample (currently line 180):
axis.TicklineColor = OxyColors.DimGray;
axis.AxislineColor = OxyColors.Red; // Doesn't seem to work.

@XamlBrewer
Copy link
Author

But I definitely see a bug here :) image

P.S. Fixed

Indeed fixed the Contour series, but now the PieChart has an issue:
PieChartLines

@HavenDV
Copy link
Owner

HavenDV commented Feb 13, 2022

Thanks for the info, I'll see what I can do tomorrow.

@VisualMelon
Copy link

VisualMelon commented Feb 13, 2022

The default for AxislineStyle is LineStyle.None: you need to set that to e.g. AxislineStyle = LineStyle.Solid if you set the AxisLineColor also (which by default is black).

See for example https://github.com/oxyplot/oxyplot/blob/develop/Source/Examples/ExampleLibrary/Axes/AxisExamples.cs#L196

@XamlBrewer
Copy link
Author

XamlBrewer commented Feb 13, 2022

This means that the behavior is as intended, so the issue may be closed. Sorry to have bothered you with this one, @HavenDV.

@HavenDV
Copy link
Owner

HavenDV commented Feb 15, 2022

Indeed fixed the Contour series, but now the PieChart has an issue:

Pie issue is a regression caused by the recent application of the PolyLineSegment workaround oxyplot/oxyplot#1848
I will investigate whether it is possible to solve all the problems at the same time.

@HavenDV
Copy link
Owner

HavenDV commented Feb 15, 2022

I reverted the PolyLineSegment fix, Pie should work correctly. But the issue shown here - oxyplot/oxyplot#1848 will come back
But there the main reason is problems on the WinUI side - microsoft/microsoft-ui-xaml#6716

@HavenDV HavenDV closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants