Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a stable v1 #73

Open
roquie opened this issue Jan 12, 2020 · 6 comments
Open

Release a stable v1 #73

roquie opened this issue Jan 12, 2020 · 6 comments

Comments

@roquie
Copy link

roquie commented Jan 12, 2020

Hi! This library is so cool for async validation in PHP. Can I help you to release a stable version?

@PeeHaa
Copy link
Contributor

PeeHaa commented Jan 14, 2020

As far as I am concerned the public API works pretty well and I don't see an issue releases a stable v1

@roquie
Copy link
Author

roquie commented Jan 14, 2020

Good. May be used stable versions for these dependencies?

https://github.com/HarmonyIO/Validation/blob/master/composer.json#L12
https://github.com/HarmonyIO/Validation/blob/master/composer.json#L33
https://github.com/HarmonyIO/Validation/blob/master/composer.json#L34

Because simple command composer require harmonyio/validation does not work without hard-installed dependencies with RC-versions, like this:

# composer `require` section 
"harmonyio/validation": "v1.0.0-rc1",
    "harmonyio/cache": "v1.0.0-rc1",
    "harmonyio/http-client": "v1.0.0-rc1"

Needs to be release these dependencies with stable versions and then update this library to 1.0.0. Please :)

@roquie roquie changed the title Library is still alive? Release a stable v1 Jan 14, 2020
@PeeHaa
Copy link
Contributor

PeeHaa commented Jan 14, 2020

Good call. Will review all dependencies and update them where needed before releasing

@roquie
Copy link
Author

roquie commented Apr 6, 2020

Do you have a time to update composer dependencies for this library? And also update "dependencies of dependencies" (harmony/cache, harmony/http-client)?

Because amphp team released new http client and in my project it conflict with old artax version in your http-client: https://github.com/HarmonyIO/Http-Client/blob/master/composer.json#L18 ?

I was glad to make a pull-request, but composer dependencies should be resolved by author. :(

@roquie
Copy link
Author

roquie commented Apr 6, 2020

IMHO, harmony/cache, harmony/http-client must be in composer section suggests, because caching/rules-with-http-requests is optional functionality.

@roquie
Copy link
Author

roquie commented Apr 16, 2020

Fuh. I'm completed work.

https://github.com/spacetab-io/harmony-validation-php
https://github.com/spacetab-io/harmony-cache-php
https://github.com/spacetab-io/harmony-http-client-php

composer require spacetab-io/harmony-validation

Works pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants