Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the amphp/uri dependency from composer #12

Open
PeeHaa opened this issue Dec 27, 2018 · 0 comments
Open

Remove the amphp/uri dependency from composer #12

PeeHaa opened this issue Dec 27, 2018 · 0 comments

Comments

@PeeHaa
Copy link
Contributor

PeeHaa commented Dec 27, 2018

We do not directly depend on amphp/uri, but we added it to be able to use the non broken version.

Broken version: 0.1.0
Non-broken version: 0.1.1

Once upstream fixed their dependency tree we should remove it.
PeeHaa added a commit that referenced this issue Dec 27, 2018
@PeeHaa
Bump version of amphp/uri indirect dependency to use a non broken ver…
793da43 
…sion

This should be reverted once upstream fixes their dependency #12. Upstream issue: amphp/dns#79
@PeeHaa PeeHaa closed this as completed in fff3f87 Apr 29, 2019
@PeeHaa PeeHaa reopened this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PeeHaa