Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer review week 2 #3

Open
RowinRuizendaal opened this issue Feb 12, 2021 · 1 comment
Open

Peer review week 2 #3

RowinRuizendaal opened this issue Feb 12, 2021 · 1 comment

Comments

@RowinRuizendaal
Copy link

Repository

  • Is there a link to the live demo at the top? ✅
    Yes there is a link to the live demo at the tap

  • Is the concept described well in the readme? ❌
    Although your diagrams tell a lot about the concept, I am missing your own words to describe the concept of what you are going to build and what API you're going to use.

  • Is the API described in the readme? ❌
    As mentioned above: no API is described in the readme

  • Are the Actor and Interaction diagrams included? ✅
    Yes, the Actor and interaction diagrams are included.

Code

  • Using the Actor diagram, figure out the structure of the code Do the actors make sense to you? ✅
    Yes the actor diagram makes sense to me

  • Do you see any function you wouldn't expect for a certain Actor? ✅
    In the Actor Diagram I see a profile function, is this function just for one specific person, or can people log in, signup, enter their details?

  • Using the interaction diagram, figure out how the app functions Do the flow make sense to you? ✅
    Yes, the interaction diagram gives me a good overview of the interactions that the app has to offer :)

  • Click through the live demo Does it work the way you would expect it to? ❌
    I can't really click through the app, but I can assume that the app contains the gametime of a certain player. although nothing really to explore yet, I am curious how you will design/code this :)

  • What features or improvements would you like to see? ✅
    Maybe have a card design, where all of the data is being shown/redirects players to a more detailed page, I am not sure if it's possible to have a form where people can leave their Gamertag to view their own records (if possible).

  • Browse the code Has it already been structured according to the diagrams? ✅
    Yes, the code has been structured according to the diagrams.

  • Check the code against our best practices ✅

When you are going to implement routie your app.js is going to be cleaner,
nice use of temple literals,
work is nice structured in modules

@HappyPantss
Copy link
Owner

Hey Rowin, little late response, but the feedback is appreciated! I will work on this as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants